Update class-kirki-fonts-google.php #2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process fonts function does not worked correctly. Fonts variants was not loaded correctly because of this (some corrent fonts variants like 100,200,300, etc was skipped and not loaded to site if load all font variants feature was enabled). Can be related only to some (PHP7+) PHP versions.
Brackets fix
Codecov Report
@@ Coverage Diff @@
## develop #2106 +/- ##
=======================================
Coverage 4.69% 4.69%
=======================================
Files 145 145
Lines 6918 6918
=======================================
Hits 325 325
Misses 6593 6593
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process Google fonts function does not worked correctly. Fonts variants was not loaded correctly because of this issue with different variables (string and integer) comparison in array (some correct fonts variants like 100,200,300, bolds, etc was skipped and not loaded to site if "load all font variants" feature was enabled).
For example if Google Font have 100,100italic,200,200italic variants - function remove 100 and 200 from variants. Now this is fixed.
Can be related only to some (PHP7+) PHP versions.