Weird outline arounds some apps #52

actionless · 2018-05-23T15:21:59Z

From @jdamboeck on February 14, 2018 19:55

Outline despite of outline=0.. also what is this glow around the windows?

oomox 1.5 arch

Copied from original issue: themix-project/themix-gui#123

actionless · 2018-05-23T15:22:01Z

outline is a border which is displayed over an item selected with keyboard (with <Tab> key)
glow is inverted shadow (for dark themes)

actionless · 2018-05-23T15:22:02Z

From @jdamboeck on February 15, 2018 13:6

Yeah... I know what an outline is. But I disabled the outline then why is it still there.
As for the shadow, there should be a switch to just keep it as a shadow instead of a glow with dark themes.

actionless · 2018-05-23T15:22:03Z

could you highlight the mistaken outline on your screenshot?
i'll be happy to merge such change

actionless · 2018-05-23T15:22:04Z

From @jdamboeck on February 15, 2018 15:37

Okay.. I made a mistake.. there is an option focused outline width. i thought it relates to the window border but its the selected item in other elements.

but there is another error.

see the attached screens:

That would be really great

actionless · 2018-05-23T15:22:04Z

does the problem happens only with Telegram (and other google-chrome/electron-based apps) ?

if so -- that could be a duplicate of this issue:
themix-project/themix-gui#121 (Slack in that ticket AFAIK is using electron)

actionless · 2018-05-23T15:22:05Z

From @jdamboeck on February 15, 2018 16:6

it happens with all windows that use a small window decoration(tool style window i think). gimp for example or the oomox popup when you export the theme.

actionless · 2018-05-23T15:22:06Z

i still can't reproduce it but let's try to debug it:

is it displayed fine if gtk theme set to oomox but WM decorations theme is different?
and if the opposite?
which WM do you use?
create a file ~/.config/gtk-3.0/gtk.css and put there:

window decoration {
	margin: 0;
	border: none;
}

restar the app and see if it helped

actionless · 2018-05-23T15:22:06Z

From @jdamboeck on February 15, 2018 17:53

i cant change my WM decorations.
i am using gnome 3.26.2
stays the same

actionless · 2018-05-23T15:22:07Z

From @jdamboeck on February 15, 2018 18:3

Okay.. After login back the faulty outline is gnone... but the outline that stays is always the focused window border color.

actionless · 2018-05-23T15:22:08Z

From @jdamboeck on February 15, 2018 18:30

and... when i change the border color... the faulty border on all tool style windows stays the same color as before. so i think there maybe an bug when applying the color to those windows.
also the courner rounding on those windows does not change.

before(retro/c64) :

after(retro/c64 modified border color and radius) :

the square is the default border color and radius
the circle is after changing it from the default state

actionless · 2018-05-23T15:22:09Z

i cant change my WM decorations.

if your WM not offering such option you can create a "fake" theme:

generate oomox theme normally
remove metacity-1 directory from the generated theme
copy that directory from some other non-oomox theme

actionless · 2018-05-23T15:22:09Z

and... when i change the border color... the faulty border on all tool style windows stays the same color as before. so i think there maybe an bug when applying the color to those windows.

are they applying after re-logging-in to the gnome?

actionless · 2018-05-23T15:22:10Z

From @jdamboeck on February 15, 2018 18:50

are they applying after re-logging-in to the gnome?

ah.. yes they do but its still the wrong color... always the focused window corder even if unfocused

actionless · 2018-05-23T15:22:11Z

From @jdamboeck on February 15, 2018 18:52

As for the metacity theme... i think gnome does not use that anymore?
most of my themes have no metacity folder. also if i delete that folder everything is still as intended

actionless · 2018-05-23T15:22:11Z

so, just to confirm it's not using metacity:

when you're doing this sequence:

change to some other theme
remove metacity-1 from oomox theme
choose back oomox theme
relogin to gnome

you're still able to reproduce the issue or you're seeing some default Adwaita titlebars?

actionless · 2018-05-23T15:22:12Z

From @jdamboeck on February 15, 2018 18:59

yes... but i can't resize the windows with csd anymore(okay.. this is because of your gtk.css changes) the buggy windows stay the same

so indeed it is using a metacity theme.
ill try adding MetacityTheme=Arc to the index.theme file

actionless · 2018-05-23T15:22:13Z

From @jdamboeck on February 15, 2018 19:7

okay.. no matter what i change it stays visually the same

actionless · 2018-05-23T15:22:13Z

then i guess now gnome is reading them from gtk theme

does editing ./oomox/plugins/theme_oomox/gtk-theme/src/gtk-3.20/scss/widgets/_window.scss have any effect for the issue? because there i don't see any separate handling of CSD and non-CSD windows, while on your screenshots i see what CSD and non-CSD windows have slightly different decorations (so i've suggested what on non-CSD windows metacity being used)

actionless · 2018-05-23T15:22:14Z

From @jdamboeck on February 15, 2018 19:55

for that i would have to compile it myself i think?

actionless · 2018-05-23T15:22:15Z

you can just edit /opt/oomox/plugins/theme_oomox/gtk-theme/src/gtk-3.20/scss/widgets/_window.scss with sudo

actionless · 2018-05-23T15:22:15Z

From @jdamboeck on February 15, 2018 19:58

nevermind... checked the source out. nothing to compile i think.

actionless · 2018-05-23T15:22:16Z

i particularly recommend playing with the line 40 (.ssd) or you can do it in your ~/.config/gtk-3.0/gtk.css

i think that .ssd class is being used by gnome for non-CSD windows

so _window.scss is clearly missing something for unfocused .ssd windows, i am wondering if gnome understands something like .ssd:backdrop

actionless · 2018-05-23T15:22:17Z

From @jdamboeck on February 15, 2018 20:36

changing .ssd does indeed change the windows in question... now im on the hunt for any documentation on that.. but good luck searching for searches with ssd as a term :D

actionless · 2018-05-23T15:22:17Z

From @jdamboeck on February 15, 2018 20:57

that did the trick

.ssd & {
    box-shadow: 0 0 0 1px $wm_border_focused;
    &:backdrop {
        box-shadow: 0 0 0 1px $wm_border_unfocused;
     }
}

actionless · 2018-05-23T15:22:18Z

From @jdamboeck on February 15, 2018 22:27

but the issue numixproject#121 is still there.. it applies the right color but there is a double border. the one from the ssd and inside that another one which does not include the titlebar.
with csd there are also 2 borders... but they include the window title too.

actionless · 2018-05-23T15:22:19Z

if you set window decoration { border-width: 0; } it looks fine but mouse not resizing the edges?

actionless · 2018-05-23T15:22:19Z

From @jdamboeck on February 16, 2018 0:29

yes

actionless · 2018-05-23T15:22:20Z

and what about:

window decoration {
border-width: $spacing + 2px;
}

window {
border-radius: $roundness / 2;
}

?

actionless · 2018-05-23T15:22:21Z

From @jdamboeck on February 16, 2018 0:34

The same as as without gtk.css

actionless · 2018-05-23T15:22:21Z

you need to compile in your head that scss snippet into css using the real values from your preset :-)

actionless · 2018-05-23T15:24:48Z

From @jdamboeck on Feb 16

i have a spacing of 3 and a roundness of 0
so my gtk.css is now:

window` decoration {
	margin: 0;
	border-width: 5px;
}

window {
	border-radius: 0;
}

actionless · 2018-05-23T15:25:03Z

hm, mb i'll have a look how that part implemented in other themes

actionless · 2018-05-23T15:25:20Z

From @jdamboeck on Feb 16

if i pick a default color presets and export it, i too get the same color as the titlebar... when i edit "focused window border" "unfocused window border" and "background" the strange double border is back again.

somehow the wrong color gets added if you edit one of the default presets. but unedited the default color presets generate themes as they should be.

edit: bit its not consistent either. sometimes it works sometimes the error is back. might depend on the colors?

maybe it helps if i send you the preset where its broken so you can test with that?

named it .txt so i can upload it to github
brainiac.txt

actionless · 2018-05-23T15:25:36Z

that black color is coming from WM_BORDER_UNFOCUS=000000

actionless · 2018-05-23T15:25:54Z

From @jdamboeck on Feb 16

Yeah but why.

actionless · 2018-05-23T15:26:11Z

From @jdamboeck on Feb 16

https://www.reddit.com/r/archlinux/comments/6duktu/adding_colored_window_borders_in_gnome/di9htfj/

if i put that part in my gtk.css it works as intended. maybe it helps finding a solution.

actionless · 2018-05-23T15:26:24Z

could you please check if the same theme still works fine in openbox?
last time when i was playing with i remember what it was working either in one place or in another.
so if it will be like that again -- mb we can have to _window.scss files and choose one for gnome or for the rest as oomox export option

actionless · 2018-05-23T15:27:22Z

From @jdamboeck on Feb 16

in openbox all is as intended

actionless · 2018-05-23T15:27:35Z

splendid! could you prepare a pull request please?

actionless · 2018-05-23T15:27:50Z

From @jdamboeck on Feb 16

what for? i did not do anything... maybe we did missunderstand each other? the theme works in openbox without me doing any changes.

actionless · 2018-05-23T15:28:01Z

if i put that part in my gtk.css it works as intended
in openbox all is as intended

actionless · 2018-05-23T15:28:24Z

From @jdamboeck on Feb 16

yeah.. but i don't really know where to apply the gtk.css changes to the oomox -gtk-theme code. never done any real gtk theming before. :D I am just trying do sherlock my way through it.

actionless · 2018-05-23T15:28:34Z

you can see similar class names in _window.scss which i mentioned few times above if you'll not manage to do so, i'll have some time mb on sunday to give it a try

actionless · 2018-05-23T15:28:54Z

From @jdamboeck on Feb 16

I will try to sherlock some more... Maybe I'll get my feet in it.

actionless · 2018-05-23T15:28:59Z

after that you could add SCSS to your CV ;P

actionless · 2018-05-23T15:29:10Z

From @jdamboeck on Feb 16

i got scss partially... i am an webdev after all but done mostly plain css and less the last years. but i don't really know the gtk specific parts in all of this.

actionless · 2018-05-23T15:29:19Z

i am not sure if it's solved in all the setups or not so better will leave it open

actionless · 2018-07-30T22:55:10Z

@pandasauce please try if any of the solutions proposed above are working in your setup

if so, please prepare a PR or at least share a patch or so

- Expand window resize area - Fix double border around windows - Fix .solid-csd styling to properly display windows in tiling window managers Fixes themix-project#52 Fixes themix-project/themix-gui#170

- Expand window resize area - Fix double border around windows - Fix .solid-csd styling to properly display windows in tiling window managers Fixes #52 Fixes themix-project/themix-gui#170

actionless added bug question submitter gone labels May 23, 2018

actionless mentioned this issue May 23, 2018

Outline despite of outline=0 themix-project/themix-gui#123

Closed

actionless changed the title ~~Outline despite of outline=0~~ Weird outline arounds some apps Jul 29, 2018

actionless mentioned this issue Jul 29, 2018

Make configurable border color of the widgets #47

Open

stevensonmt mentioned this issue Aug 12, 2018

Window Title Bar Height #53

Closed

nana-4 mentioned this issue Nov 10, 2018

Fix various window decoration problems #56

Merged

actionless closed this as completed in #56 Nov 10, 2018

Weird outline arounds some apps #52

Weird outline arounds some apps #52

Comments

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018 • edited Loading

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018 • edited Loading

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented May 23, 2018

actionless commented Jul 30, 2018

actionless commented May 23, 2018 •

edited

Loading

actionless commented May 23, 2018 •

edited

Loading