fix bug images not shown in case two images size are almost same. #39
Conversation
minhlucvan
changed the title
minhlucvan
changed the title
|
You mean you have 2 images, which are totally different, but same size, and they cause lightbox to stuck at spinning ? |
|
yes it is, the different of images size (two different images) are too small so the "transitionend" event can not fired and the lightbox stuck at spinning. |
|
Hi there, I have tried on my local and everything seems fine. I use 2 images, one has 300x300 and another one uses 297x297 and it works flawlessly. It is great if you can provide some image examples if possible. Also it can be duplicated from #12 |
|
|
|
Hi |
|
Ok so both images are the same right ? |
|
Can someone submit please? :) |
|
Ok i think i will try to merge this and push new update in a few hours |
|
thank you, btw sorry for my unfamiliarity but can someone publish a new version 1.4.1 ? |
|
Sorry forgot to publish version. 1.4.1 should be on npm now |
themyth92/angular2-lightbox@9c2c9dd themyth92/angular2-lightbox#39 (comment) disclaimer: i did not actually test this
Hello world.
Recently I have a project that use angular2-lightbox, but there is one problem is my images are almost same size but a little bit different about some pixels, in that case when user click on the "Next" button the lightbix is getting freeze and the loader spinning forever.
I was debug and found the problem was the "transitionend" is not fired because the images size that I mentioned above. I have fixed this issue and want to make a pull request for any one have same problem.
Thank you.