-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed identifier of bound functions on node 4 #9
Conversation
can you add a test? |
There seems to be a problem with Travis relating to Node 0.8, but here is the test output after all commits in this PR:
|
oh feel free to remove |
Not sure how you like commits structured, but I can squash these if desired. |
nope these are great because your commits names all make sense 👍 |
merged 1a26a74 |
Hi, is there a reason why this problem have not been fixed for "withCallback" version? |
fixed in acdcd59 |
thank you |
Originally detected while using co-redis; thenify breaks libraries that depend on it when using Node 4.x and bound functions are passed to
eval
/createWrapper
.This is because the function name
'bound '
contains a space, making it an illegal identifier.This commit fixes this in accordance with the same fix here.