Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite - type-based assertions and better diffing. #341

Merged
merged 48 commits into from
May 6, 2021

Conversation

yeldiRium
Copy link
Contributor

@yeldiRium yeldiRium commented Apr 23, 2021

BREAKING CHANGE:

Many assertions are now only usable with types they make sense for. This should probably not break much code, but also probably will. Not entirely sure about the repercussions these changes will have.

Some rarely used assertions have been removed (e.g. between).

Some have been added: Support for Results, Maps, Sets and Errors.

Error messages are now much more informational and dare I say beautiful, since the new implementation is based on an in-depth diffing algorithm based on value equality.

@goloroden goloroden marked this pull request as ready for review May 5, 2021 15:19
@goloroden
Copy link
Member

@yeldiRium Whenever you want to – feel free to merge 😊🎉

@yeldiRium yeldiRium merged commit f6c430f into main May 6, 2021
@yeldiRium yeldiRium deleted the feat/rewrite branch May 6, 2021 13:18
goloroden pushed a commit that referenced this pull request May 6, 2021
# [6.0.0](5.2.8...6.0.0) (2021-05-06)

### Features

* Rewrite - type-appropriate assertions and better diffs. ([#341](#341)) ([f6c430f](f6c430f))

### BREAKING CHANGES

* Many assertions are now only usable with types they make sense for. This should probably not break much code, but also probably will. Not entirely sure about the repercussions these changes will have.

Some rarely used assertions have been removed (e.g. between).
Some have been added: Support for Results, Maps, Sets and Errors.
Recursions in asserted values are now recognized and in most cases even correctly compared (excluding maps and sets).

Error messages are now much more informational and dare I say beautiful, since the new implementation is based on an in-depth diffing algorithm based on value equality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants