-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rewrite - type-based assertions and better diffing. #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite parts of the array diffing logic so that comparisons with `blank` are no longer necessary.
goloroden
approved these changes
May 5, 2021
@yeldiRium Whenever you want to – feel free to merge 😊🎉 |
goloroden
pushed a commit
that referenced
this pull request
May 6, 2021
# [6.0.0](5.2.8...6.0.0) (2021-05-06) ### Features * Rewrite - type-appropriate assertions and better diffs. ([#341](#341)) ([f6c430f](f6c430f)) ### BREAKING CHANGES * Many assertions are now only usable with types they make sense for. This should probably not break much code, but also probably will. Not entirely sure about the repercussions these changes will have. Some rarely used assertions have been removed (e.g. between). Some have been added: Support for Results, Maps, Sets and Errors. Recursions in asserted values are now recognized and in most cases even correctly compared (excluding maps and sets). Error messages are now much more informational and dare I say beautiful, since the new implementation is based on an in-depth diffing algorithm based on value equality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
Many assertions are now only usable with types they make sense for. This should probably not break much code, but also probably will. Not entirely sure about the repercussions these changes will have.
Some rarely used assertions have been removed (e.g.
between
).Some have been added: Support for
Result
s,Map
s,Set
s andError
s.Error messages are now much more informational and dare I say beautiful, since the new implementation is based on an in-depth diffing algorithm based on value equality.