fix: perform type check during qa command
#708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeldiRium
previously approved these changes
Sep 1, 2021
goloroden
requested changes
Sep 1, 2021
goloroden
approved these changes
Sep 3, 2021
goloroden
pushed a commit
that referenced
this pull request
Sep 3, 2021
## [12.2.4](12.2.3...12.2.4) (2021-09-03) ### Bug Fixes * perform type check during `qa` command ([#708](#708)) ([66c790b](66c790b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The roboter has many commands, the default command is
qa. This command is used in CI and locally as the standard way to perform quality assurance. It should identify all problems that can be found by static analysis and report them.The current version does not build Typescript during the
qacommand, causing type errors to be unreported. This PR adds type checking using the TypeScript compiler to theqacommand. No code is generated during this phase.