Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1682] Project HIFI #1753

Merged
merged 65 commits into from
May 29, 2021
Merged

[#1682] Project HIFI #1753

merged 65 commits into from
May 29, 2021

Conversation

jamessspanggg
Copy link
Contributor

@jamessspanggg jamessspanggg commented Apr 23, 2021 •
edited
Loading

Fixes #1682

  • Custom button and project cards component
  • Basic Responsive Landing page
  • Define APIs and their types
  • Populate api-dev with dummy data
  • Hook up APIs
  • Project details page
  • Project scrolling behavior
  • Add new icons from thenewboston/ui, awaiting Add new project icons ui-js#19 to be merged and published to npm
  • Utilise new font system, awaiting [#1702] Font UI Update #1733 to be merged
  • Added new light weight date formatter package, fecha
  • Tested with Safari, Chrome, iOS safari and iOS chrome
  • Setup redux (optional)

Dependencies:

@jamessspanggg jamessspanggg mentioned this pull request Apr 23, 2021
Closed
@jamessspanggg jamessspanggg mentioned this pull request May 1, 2021
Closed
@jamessspanggg jamessspanggg marked this pull request as ready for review May 1, 2021 16:45
@jamessspanggg jamessspanggg requested review from angle943 and ma2b0043 May 1, 2021 16:45
@jamessspanggg jamessspanggg mentioned this pull request May 2, 2021
Closed
@angle943 angle943 mentioned this pull request May 25, 2021
Closed
@buckyroberts
Copy link
Collaborator

@angle943 deployed to prod thenewboston-blockchain/Website-API#105

@angle943 angle943 mentioned this pull request May 27, 2021
Closed
@angle943 angle943 mentioned this pull request May 29, 2021
Closed
jamessspanggg
jamessspanggg commented May 29, 2021
View reviewed changes
Copy link
Contributor Author

@jamessspanggg jamessspanggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@buckyroberts buckyroberts merged commit b91421f into thenewboston-blockchain:development May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThaDeveloper ThaDeveloper ThaDeveloper left review comments

@angle943 angle943 angle943 approved these changes

@ma2b0043 ma2b0043 Awaiting requested review from ma2b0043

@RajputUsman RajputUsman Awaiting requested review from RajputUsman

@buckyroberts buckyroberts Awaiting requested review from buckyroberts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projects hifi
4 participants
@jamessspanggg @buckyroberts @angle943 @ThaDeveloper