Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Change types with multiple values to enum #158

Closed
tomijaga opened this issue Apr 29, 2021 · 0 comments · Fixed by #157
Closed

[Task] Change types with multiple values to enum #158

tomijaga opened this issue Apr 29, 2021 · 0 comments · Fixed by #157
Labels
PR Reward - 25 Reward in coin(s)

Comments

@tomijaga
Copy link
Contributor

tomijaga commented Apr 29, 2021

Task

Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!

Overview

Switch all the types with multiple values to enum's so they are compatible with the account manager repo

Behavior

export type NodeType = "BANK" | "CONFIRMATION_VALIDATOR" | "PRIMARY_VALIDATOR";

to

export enum NodeType{
 bank = "BANK",
 confirmationValidator = "CONFIRMATION_VALIDATOR",
 primaryValidator = "PRIMARY_VALIDATOR",
}

Please ask for this task to be assigned to you and earn and its sweet reward 😉

Remember to include your account number in your PR description for us to pay you 💰

** Pull Requests **
All Pull Request should be made to development branch, read contributors guild for more information about contributing

@tomijaga tomijaga changed the title [Task] Add All Confirmation Validator Tests [Task] Change types with multiple values to enum Apr 29, 2021
@zinoadidi zinoadidi added the PR Reward - 25 Reward in coin(s) label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR Reward - 25 Reward in coin(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants