Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replaced type with enum for types with multiple values #157

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

tomijaga
Copy link
Contributor

@tomijaga tomijaga commented Apr 26, 2021


name: Pull Request
about: 'replace types with Enum'
title: 'feat: Replaced type with enum for types with multiple values'

Description

Switch all the types with multiple values to enum's so they are compatible with the account manager repo

Resolves: #158

Type of change

  • Chore (chore: description-of-task)
  • Fix (fix: description-of-fix)
  • Feature (feat: description-of-fix)
  • Docs (docs: description-of-docs-added-or-modified)
  • Test (test: description-of-tests-performed)
  • Refactor (refactor: description-of-refactor)

Please specify the type of change in your title following the above format

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tomijaga
Copy link
Contributor Author

@zinoadidi When you are done reviewing the code can you also update the npm package.

@zinoadidi
Copy link
Contributor

HI @tomijaga could you create a task for this as well.
Thanks!

@zinoadidi zinoadidi self-requested a review April 27, 2021 18:42
@zinoadidi zinoadidi changed the title Replaced type with enum for types with multiple values feat: Replaced type with enum for types with multiple values Apr 27, 2021
@zinoadidi zinoadidi merged commit cab172b into thenewboston-blockchain:development Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Change types with multiple values to enum
2 participants