Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add "fee" Field in Transactions #61

Closed
AbhayAysola opened this issue Mar 4, 2021 · 0 comments · Fixed by #62
Closed

[Task] Add "fee" Field in Transactions #61

AbhayAysola opened this issue Mar 4, 2021 · 0 comments · Fixed by #62
Labels
Bug Bounty Owed - 25 Reward in coin(s) enhancement New feature or request Paid PR Reward - 50 Reward in coin(s)

Comments

@AbhayAysola
Copy link
Contributor

Task

Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!

Overview

The latest version of thenewboston bank uses a new field in transactions called fee. This field is used to differentiate normal transactions from transactions which are sent as fees to either banks or validators.

Behavior

The task is to add this field to the library as currently it is not possible to send coins using this library.

Please ask for this task to be assigned to you and earn and its sweet reward 😉

Remember to include your account number in your PR description for us to pay you 💰

@zinoadidi zinoadidi added PR Reward - 25 Reward in coin(s) enhancement New feature or request PR Reward - 50 Reward in coin(s) and removed PR Reward - 25 Reward in coin(s) enhancement New feature or request PR Reward - 50 Reward in coin(s) labels Mar 4, 2021
@zinoadidi zinoadidi added the PR Reward - 50 Reward in coin(s) label Mar 4, 2021
zinoadidi pushed a commit that referenced this issue Mar 4, 2021
zinoadidi added a commit that referenced this issue Mar 5, 2021
* Add fee field #61 (#62)

* Lint command does not fail

* All contributions to be made from development branch

* Publish should work correctly (#63)

* fix: invalid parameter in publish command (#64)

* Publish should work correctly

* Package access is set to public on publish

* increment version number (#66)

* Publish should work correctly

* Package access is set to public on publish

* 1.0.2

* Send database synchronisable idempotent payment #57 (#59)

* Send database synchronisable idempotent payment #57

* create TransferDetails class

Co-authored-by: Abhay <67417765+AbhayAysola@users.noreply.github.com>
@zinoadidi zinoadidi added the Bug Bounty Owed - 25 Reward in coin(s) label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bounty Owed - 25 Reward in coin(s) enhancement New feature or request Paid PR Reward - 50 Reward in coin(s)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants