-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] Fix npm deployments (extra 2000 TNBC bounty available) #69
Comments
If this is closed in the next 24 hours, I will personally pay an additional bounty of 2000 TNBC. |
Would be nice if all issues identified that are not yet resolved concerning deployment are fixed through this issue. |
I was thinking we could do a releases workflow first and then do |
@AbhayAysola whatever works long term is fine. I like the workflow idea. Maybe run build on GitHub actions and publish that. |
I meant using Github Releases. It's up to the repo maintainer to decide whether we have Releases or not. |
Task
Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!
Overview
When you run
npm install thenewboston
, there's nodist
directory. You can't then justrequire("thenewboston")
without going insidenode_modules/thenewboston
and runningnpm install && npm run build
first.If you
require("thenewboston")
without going inside the module and runningnpm install && npm run build
first, you get an error:When you
npm install
in your project root, the TNB module resets and you have to manually go in and set it up again.Behavior
This task is complete when you can do
npm install thenewboston
and that installs with thedist
directory already there (preferably deploy that directory to npm for faster installs but a pre-install script works too if that's a thing).Please ask for this task to be assigned to you and earn and its sweet reward 😉
Remember to include your account number in your PR description for us to pay you 💰
The text was updated successfully, but these errors were encountered: