-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Task] generateAccount function in Account manager uses JS SDK #98
Comments
We can generate an account by just using |
Shouldn't this be in the Account Manager Repo? |
@tomijaga to be honest i want to have them here for better management of the tasks; The final bounty will be paid out as specified on the main task in the account manager Here we can track the process of integration and make changes to SDK as needed when and if things arise during the integration process. For instance, if during the switching you find a new method that is missing, then the PR for such method on SDK would reference this task or related task |
Yh this makes sense |
@tomijaga i will work on publishing a new version to npm; |
@zinoadidi I'm ready. I can start working on it once the npm package is published. |
@tomijaga it's published. update me how it goes, what problems you face, etc |
@zinoadidi Done with the account functions. Need to get the code reviewed and merge before i can move on to the next class |
All merge can go to the branch created for this integration task, let's get any one who is active on account manager repo to look at it and merge after. I would say once all work relating to account section is done, then we can look at getting Justin involve and see how we can get the updates to development branch. So we just do it batch by batch basically |
@tomijaga i looked at PR, seems you have done already all account-related things. Good job! I guess we wait for Justin, not sure he will give us write access but i will leave a comment as well. Will create the next set of tasks |
Yh I hope he gives us access. It will make it faster. I can just push the changes and have him review when it's all done |
Tasks are now created; you can filter issues / tasks relating to this project with |
@zinoadidi I also found some functions that are missing from the sdk:
I will create tasks for them |
@tomijaga it gets even better now; |
Task
Contributors are able to complete this task and earn thenewboston coins. Check out the labels to learn how much you can earn for contributing by completing this task. Please make sure to be honest if you wish to contribute by saying you can't finish this and we can just un-assign you with no harm done! There is no point in delaying tasks from being completed for miscommunication!
Overview
generateAccount function in Account manager uses JS SDK
thenewboston-js
repo Account-Manager#585Behavior
Account manager uses js sdk installed from NPM https://www.npmjs.com/package/thenewboston
createBlock function in Account manager uses JS SDK
/* code examples are awesome */
Please ask for this task to be assigned to you and earn and its sweet reward 😉
Remember to include your account number in your PR description for us to pay you 💰
The text was updated successfully, but these errors were encountered: