-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bulk payments #82
feat: Bulk payments #82
Conversation
i think internal methods can stay private; As I understand, all future transactions need to be in an array, single or multiple yes? also, I created and linked an issue to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add tests/update existing tests as well
@zinoadidi yh all transactions have to be in an array. Are u saying that I should remove the |
@tomijaga i think it's fine to leave the |
@tomijaga needs also tests then me can merge it and move to next one |
@zinoadidi I'm currently doing school work rn but i will get the tests done at the end of the day. You can put up issues for the other changes and i will get to them as time permits me |
Resolves: #83
Implemented Bulk Payments.
I don't know if this is the best implementation.
I used the Transaction[] type instead of the TransferDetails class for the
methods
createTransaction()
andsendBulkTransactions()
Also Should i make the internal methods private