Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bulk payments #82

Merged
merged 4 commits into from
Mar 28, 2021

Conversation

tomijaga
Copy link
Contributor

@tomijaga tomijaga commented Mar 26, 2021

Resolves: #83

Implemented Bulk Payments.

I don't know if this is the best implementation.
I used the Transaction[] type instead of the TransferDetails class for the
methods createTransaction() and sendBulkTransactions()

Also Should i make the internal methods private

@zinoadidi zinoadidi self-requested a review March 26, 2021 06:47
@zinoadidi
Copy link
Contributor

zinoadidi commented Mar 26, 2021

i think internal methods can stay private;
this feature contains breaking changes so we (I) will need to make sure it's properly reflected for users.
we will need to add tests as well as update existing ones that should be broken now due to the change.

As I understand, all future transactions need to be in an array, single or multiple yes?

also, I created and linked an issue to it

@zinoadidi zinoadidi linked an issue Mar 26, 2021 that may be closed by this pull request
Copy link
Contributor

@zinoadidi zinoadidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add tests/update existing tests as well

@tomijaga
Copy link
Contributor Author

@zinoadidi yh all transactions have to be in an array. Are u saying that I should remove the sendCoins() method. And instead, just have one method that can send single and multiple transactions

@zinoadidi
Copy link
Contributor

@tomijaga i think it's fine to leave the sendCoin there.
but logically, it will be an obsolute means but makes sense to have something where user can show the correct intent what kind of transaction they are performing

@zinoadidi
Copy link
Contributor

@tomijaga needs also tests then me can merge it and move to next one

@tomijaga
Copy link
Contributor Author

@zinoadidi I'm currently doing school work rn but i will get the tests done at the end of the day. You can put up issues for the other changes and i will get to them as time permits me

@zinoadidi zinoadidi changed the title Bulk payments feat: Bulk payments Mar 28, 2021
@zinoadidi zinoadidi merged commit 28b3ca9 into thenewboston-blockchain:development Mar 28, 2021
@tomijaga tomijaga changed the title feat: Bulk payments Bulk payments Mar 29, 2021
@tomijaga tomijaga changed the title Bulk payments feat: Bulk payments Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Bulk payments (feature | tests | docs)
2 participants