Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual editor shortcode bug #13

Open
misfist opened this issue Apr 20, 2017 · 2 comments
Open

Visual editor shortcode bug #13

misfist opened this issue Apr 20, 2017 · 2 comments
Labels

Comments

@misfist
Copy link
Collaborator

misfist commented Apr 20, 2017

Moved from thenewinquiry/tni-theme#58

When using the visual editor for posts with [popover] shortcodes, line breaks get added for some reason?

@misfist misfist added the bug label Apr 20, 2017
@misfist
Copy link
Collaborator Author

misfist commented Apr 20, 2017

This is actually also in the plugin because we don't want shortcodes to stop workinig if the theme is changed.

This issue seems to be related to Shortcode UI, not the shortcode itself. Shortcode UI provides the interface to add the shortcode via fields and it renders it in the visual editor (so users can preview what it's going to look like [sort of]). When I disable shortcode UI, the shortcode no longer has p tags added when switching to the visual editor.

So, I'm wondering if you want to disable shortcode UI until I can figure out a solution?

BTW. I added a ticket for this wp-shortcake/shortcake#721

@misfist
Copy link
Collaborator Author

misfist commented Apr 20, 2017

The plugin has been disabled until this issue can be resolved.

misfist added a commit that referenced this issue Apr 20, 2017
Disabled Shortcode UI integration until we can resolve issue of `<p>` tags being added when switching to visual edit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant