-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splicing slides intermittently creates blank slides #27
Comments
I am having a similar issue, although it only happens when it's the last item left in an array. |
Could you prepare a plunkr (maybe starting from this one) to reproduce the issue? |
I think this illustrates this issue when adding slides. Not sure if it does the same for removing slides: http://plnkr.co/edit/snzP7sgG7ymXOqYD0JkX?p=preview |
This one seems to fix the issue with my updated fork: http://plnkr.co/edit/ZvPns7JnJ4zHMCRfjqoI?p=preview (clicking add slides doesn't do a total refresh and only show 4 slides) |
@wilsonwc could you file a PR with the fix? |
I am testing this with an array of 10 slides and while adding slides and shifting works fine, when I try to splice by index, I start getting blank slides after a few splices.
The text was updated successfully, but these errors were encountered: