Remove random number seeds in tests #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Turns out that this is not quite as simple as I thought because some of the random numbers are generated in places where we cannot simply overwrite the random numbers with the user specified ones. Additional structures (especially in the case of The alternative would be to run the calculation multiple times and exit when at least one succeeds (but there are no guarantees still) |
kimt33
added a commit
that referenced
this pull request
May 26, 2018
Skip test `test_rank2_geminal_template_params` because it does not work all the time. In producing `template_params`, random noise is added and some of the random noise would cause errors. This test is skipped to play well with Travis. At the moment, rank2 approximation is not too important, so it is not absolutely essential to fully cover the code. Issue #59 and PR #63 address this problem, but it is not yet resolved. Until it become resolved, this test can be skipped
1. Remove seed in test_math_tools, test_chemical 2. Cannot remove seed in test_doci because the random number is generated inside cma module 3. Cannot remove seed in test_rank2_approx because the random number is generated inside property template_params
kimt33
added a commit
that referenced
this pull request
Aug 8, 2019
Since random numbers are introduced, the template_params is not determininstic and causes some headache with testing on different systems (see Issue #59 and PR #63). Even still, random numbers are introduced to easily obtain "unbaised" denominator that gives determinant that are approximately 1 (at the very least, nonsingular)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to remove the random number seeds in tests so that the tests are not system dependent. Addresses Issue #59