Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some guidance for keeping the Changelog up-to-date #322

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 4, 2024

This is one of the smaller items on the list in #313.

For more details, see https://keepachangelog.com/en/1.1.0/ (It is written for Markdown, but easy enough to follow the same practices in restructured text.) This is not a big change, mainly providing some more guidance on how to write helpful changelogs.

This is mainly going to be of use when we have a first stable release, but it is better to have it in place already before that time.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't currently review documentation changes - Let us know if you'd like us to change this.

Copy link

deepsource-io bot commented Jun 4, 2024

Here's the code health analysis summary for commits ac9a6d5..9d3d280. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@tovrstra
Copy link
Member Author

tovrstra commented Jun 4, 2024

I'll YOLO-merge this on Wednesday, June 12, unless reviewed earlier.

Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems like a good idea.

I'm curious (unless I'm missing something, this is a manual changelog format) whether we can do something automated. E.g., can we have a template for a pull request that ends up automatically updating the change log?

Probably not worth the effort to automate, though, especiall for a relatively mature packages like iodata.

@tovrstra
Copy link
Member Author

tovrstra commented Jun 5, 2024

Thanks for the comments.

I know there are scripts to extract the changelog from the commit history, but using these correctly is hard. It is not only a matter of creating the scripts that do such work. That biggest hurdle is to get everyone to format their commit messages or pull requests, such that the changelog looks good in the end. The guideline I'm linking to advices against such tools. I haven't really tried this myself.

With AI, it may be possible to derive nice changelogs from the Git history, but that seems a little too crazy right now. Who knows, one day ...

@tovrstra tovrstra merged commit 24fbd46 into theochem:main Jun 5, 2024
10 checks passed
@tovrstra tovrstra deleted the changelog branch June 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants