Remove import_resources try-except block

[tovrstra]

Another small item on the list of #313

These weird imports were only relevant for Python versions that are past their end of life: 3.6 and older.

Summary by Sourcery

This pull request removes the try-except blocks used for importing 'importlib_resources' to support older Python versions (3.6 and older). The code now directly imports from 'importlib.resources', simplifying the import statements and removing compatibility code for unsupported Python versions.

• Enhancements:
  • Removed try-except blocks for importing 'importlib_resources' in favor of direct imports from 'importlib.resources'.

[deepsource-io]

Here's the code health analysis summary for commits ac9a6d5..4735809. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[tovrstra]

This is another rather mechanical change, nothing special. I'll YOLO-merge Wednesday, June 12 unless approved earlier.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request removes the try-except block for importing 'importlib_resources' and 'importlib.resources' in various test files. The try-except block was previously used to support Python versions 3.6 and older, which are now past their end of life. The changes ensure that only 'importlib.resources' is imported directly.

File-Level Changes

Files

Changes

iodata/test/test_charmm.py iodata/test/test_chgcar.py iodata/test/test_cube.py iodata/test/test_extxyz.py iodata/test/test_gamess.py iodata/test/test_gaussianinput.py iodata/test/test_gaussianlog.py iodata/test/test_gromacs.py iodata/test/test_locpot.py iodata/test/test_mwfn.py iodata/test/test_orcalog.py iodata/test/test_cli.py iodata/test/test_fcidump.py iodata/test/test_json.py iodata/test/test_wfn.py iodata/test/common.py iodata/test/test_cp2klog.py iodata/test/test_fchk.py iodata/test/test_inputs.py iodata/test/test_iodata.py iodata/test/test_mol2.py iodata/test/test_molden.py iodata/test/test_molekel.py iodata/test/test_overlap.py iodata/test/test_pdb.py iodata/test/test_poscar.py iodata/test/test_qchemlog.py iodata/test/test_sdf.py iodata/test/test_wfx.py iodata/test/test_xyz.py

Removed try-except block for importing 'importlib_resources' and 'importlib.resources' and directly imported 'as_file' and 'files' from 'importlib.resources'.

[sourcery-ai]

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Testing: 20 issues found
• 🟢 Complexity: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[sourcery-ai]

suggestion (testing): Add test for import error handling

Consider adding a test case to ensure that the import error handling is no longer necessary. This can help verify that the codebase is fully compatible with the current Python versions.

Suggested change

	from importlib.resources import as_file, files
	import unittest
	from importlib.resources import as_file, files
	class TestImportLibResources(unittest.TestCase):
	def test_imports(self):
	try:
	from importlib.resources import as_file, files
	except ImportError:
	self.fail("importlib.resources import failed")

[sourcery-ai]

suggestion (testing): Check for redundant imports

Since the import statement is now simplified, ensure that there are no redundant imports in the test files. This will help keep the code clean and maintainable.

Suggested change

	from importlib.resources import as_file, files
	from importlib.resources import as_file

[sourcery-ai]

suggestion (testing): Add test for importlib.resources

Consider adding a test case specifically for the importlib.resources module to ensure it behaves as expected in different environments.

[sourcery-ai]

suggestion (testing): Check for redundant imports

Since the import statement is now simplified, ensure that there are no redundant imports in the test files. This will help keep the code clean and maintainable.

Suggested change

	from importlib.resources import as_file, files
	from importlib.resources import as_file

[sourcery-ai]

suggestion (testing): Add test for importlib.resources

Consider adding a test case specifically for the importlib.resources module to ensure it behaves as expected in different environments.

[sourcery-ai]

suggestion (testing): Remove redundant try-except block

The try-except block for importlib_resources is no longer necessary. Ensure that the test environment is updated to reflect this change.

Suggested change

	try:
	from importlib_resources import as_file, files

[sourcery-ai]

suggestion (testing): Remove redundant try-except block

The try-except block for importlib_resources is no longer necessary. Ensure that the test environment is updated to reflect this change.

Suggested change

	try:
	from importlib_resources import as_file, files

[sourcery-ai]

suggestion (testing): Remove redundant try-except block

The try-except block for importlib_resources is no longer necessary. Ensure that the test environment is updated to reflect this change.

Suggested change

	try:
	from importlib_resources import as_file, files

[sourcery-ai]

suggestion (testing): Remove redundant try-except block

The try-except block for importlib_resources is no longer necessary. Ensure that the test environment is updated to reflect this change.

Suggested change

	try:
	from importlib_resources import as_file, files

[sourcery-ai]

suggestion (testing): Remove redundant try-except block

The try-except block for importlib_resources is no longer necessary. Ensure that the test environment is updated to reflect this change.

Suggested change

	try:
	from importlib_resources import as_file, files

[PaulWAyers]

fine by me

[tovrstra]

Thanks for checking.