Include warning checks in molden unit test

[tovrstra]

This change now explicitly tests the expected warnings in one of the unit tests for the Molden format. See #313 for the bigger picture.

I'm planning to YOLO-merge this on Thursday, June 13 unless reviewed earlier.

Summary by Sourcery

This pull request enhances the Molden format unit test by adding explicit checks for expected warnings and refactors the test function to use parameterized test cases for improved readability and maintainability.

• Tests:
  • Added explicit checks for expected warnings in the Molden format unit test using pytest's warning mechanism.
  • Refactored the test_load_molden_cfour function to use pytest's parameterized test cases for better readability and maintainability.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds explicit tests for expected warnings in the unit tests for the Molden format. The changes involve refactoring the test_load_molden_cfour function to use pytest.mark.parametrize for better readability and maintainability, and to include checks for warnings using pytest.warns.

File-Level Changes

Files	Changes
iodata/test/test_molden.py	Refactored the test_load_molden_cfour function to use parameterized tests and added explicit warning checks.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[deepsource-io]

Here's the code health analysis summary for commits 4437bbf..d53b22a. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sourcery-ai]

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟡 Testing: 3 issues found
• 🟢 Complexity: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[PaulWAyers]

LGTM

[tovrstra]

Thanks...