Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning by using our factorial2 wrapper #329

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 7, 2024

This PR solves a SciPy warning due to the deprecated use of the factorialk function. The solution is to use our factorial2 wrapper. See #313 for the bigger picture.

I'm planning to YOLO-merge this on Thursday, June 13 unless reviewed earlier.

Summary by Sourcery

This pull request addresses a SciPy warning by replacing the deprecated factorialk function with the factorial2 wrapper in the iodata/formats/cp2klog.py file.

  • Bug Fixes:
    • Replaced deprecated factorialk function with the factorial2 wrapper to resolve SciPy warning.

Copy link
Contributor

sourcery-ai bot commented Jun 7, 2024

Reviewer's Guide by Sourcery

This pull request addresses a SciPy warning by replacing the deprecated factorialk function with the factorial2 wrapper in the iodata/formats/cp2klog.py file.

File-Level Changes

Files Changes
iodata/formats/cp2klog.py Replaced deprecated factorialk function with factorial2 wrapper to resolve SciPy warning.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

deepsource-io bot commented Jun 7, 2024

Here's the code health analysis summary for commits 4437bbf..43911a6. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

iodata/formats/cp2klog.py Show resolved Hide resolved
@tovrstra tovrstra changed the title Fix warning by usig our factorial2 wrapper Fix warning by using our factorial2 wrapper Jun 7, 2024
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovrstra
Copy link
Member Author

tovrstra commented Jun 7, 2024

Thanks!

@tovrstra tovrstra merged commit e80a025 into theochem:main Jun 7, 2024
10 checks passed
@tovrstra tovrstra deleted the warning-factorial branch June 7, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants