-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix warning by using our factorial2 wrapper #329
Conversation
Reviewer's Guide by SourceryThis pull request addresses a SciPy warning by replacing the deprecated File-Level Changes
Tips
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
This PR solves a SciPy warning due to the deprecated use of the
factorialk
function. The solution is to use ourfactorial2
wrapper. See #313 for the bigger picture.I'm planning to YOLO-merge this on Thursday, June 13 unless reviewed earlier.
Summary by Sourcery
This pull request addresses a SciPy warning by replacing the deprecated
factorialk
function with thefactorial2
wrapper in theiodata/formats/cp2klog.py
file.factorialk
function with thefactorial2
wrapper to resolve SciPy warning.