Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test documentation build in pull requests #333

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Conversation

tovrstra
Copy link
Member

@tovrstra tovrstra commented Jun 13, 2024

This is the extension of #331 towards the documentation build. These are now also built for each PR and required to pass without error or warning. (Includes a few typo fixes.)

For the bigger picture, see #313

Summary by Sourcery

This pull request extends the Sphinx documentation build workflow to run on pull requests, ensuring that documentation builds pass without errors or warnings. It also includes minor typo fixes in the workflow configuration.

  • CI:
    • Updated the Sphinx GitHub Actions workflow to run on pull requests in addition to pushes to the main branch.
    • Configured the Sphinx build to treat warnings as errors and continue on warnings, ensuring a clean build.

Copy link

deepsource-io bot commented Jun 13, 2024

Here's the code health analysis summary for commits 4896520..394178e. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link
Contributor

sourcery-ai bot commented Jun 13, 2024

Reviewer's Guide by Sourcery

This pull request extends the functionality of the documentation build process by ensuring that documentation is built and verified for each pull request. It includes changes to the GitHub Actions workflow files to trigger documentation builds on pull requests and introduces stricter error handling for the Sphinx build process. Additionally, it includes minor typo fixes.

File-Level Changes

Files Changes
.github/workflows/sphinx.yaml
.github/workflows/release.yaml
Updated GitHub Actions workflows to include documentation build checks on pull requests and fixed minor typos.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/sphinx.yaml Outdated Show resolved Hide resolved
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Copy link
Member

@PaulWAyers PaulWAyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tovrstra
Copy link
Member Author

Thanks for reviewing!

@tovrstra tovrstra merged commit 6350b9e into theochem:main Jun 13, 2024
12 checks passed
@tovrstra tovrstra deleted the pr-docs branch June 13, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants