-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test documentation build in pull requests #333
Conversation
Here's the code health analysis summary for commits Analysis Summary
|
Reviewer's Guide by SourceryThis pull request extends the functionality of the documentation build process by ensuring that documentation is built and verified for each pull request. It includes changes to the GitHub Actions workflow files to trigger documentation builds on pull requests and introduces stricter error handling for the Sphinx build process. Additionally, it includes minor typo fixes. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reviewing! |
This is the extension of #331 towards the documentation build. These are now also built for each PR and required to pass without error or warning. (Includes a few typo fixes.)
For the bigger picture, see #313
Summary by Sourcery
This pull request extends the Sphinx documentation build workflow to run on pull requests, ensuring that documentation builds pass without errors or warnings. It also includes minor typo fixes in the workflow configuration.