Add command-line option --allow-changes to iodata-convert

[tovrstra]

This addresses one of the steps of #191. The iodata-convert script gets an option to decide whether a (not trivially reversible) conversion of data should raise an error (default) or a warning (with the option). The default is not error when there is data degradation, out of an abundance of caution.

Summary by Sourcery

This pull request introduces a new command-line option --allow-changes to the iodata-convert script, allowing users to permit non-trivially reversible data conversions with warnings. The convert function has been updated to support this new option, and corresponding unit tests have been added to ensure its correct functionality.

• New Features:
  • Added a command-line option --allow-changes to the iodata-convert script, allowing users to permit non-trivially reversible conversions with warnings instead of errors.
• Enhancements:
  • Updated the convert function to handle the new allow_changes parameter, enabling conditional data modification for compatibility with the output format.
• Tests:
  • Introduced new unit tests to verify the behavior of the --allow-changes option, including scenarios where data degradation is allowed and where it raises errors.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces a new command-line option --allow-changes to the iodata-convert script, allowing users to permit data reorganization to ensure compatibility with the output format. The convert function and associated tests have been updated to support and verify this new functionality.

File-Level Changes

Files	Changes
iodata/test/test_cli.py iodata/__main__.py	Introduced and integrated the --allow-changes command-line option, updated the convert function to handle this new parameter, and added corresponding unit tests.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[deepsource-io]

Here's the code health analysis summary for commits 4dceda6..0a4d979. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
Shell	✅ Success		View Check ↗
Python	✅ Success		View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[sourcery-ai]

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟡 Testing: 3 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[PaulWAyers]

Sourcery is really incredible at this....catches spelling errors even. Wow.

No concerns with this; the bot's a better reviewer than me ...

[tovrstra]

Thanks for the quick check. I'm going to fix that and follow one of its suggestions for unit tests. Sourcery sometimes has a good idea of what still needs testing, but actual code changes still require some human oversight. (Or I am too picky.)

[tovrstra]

@sourcery-ai review

[sourcery-ai]

Hey @tovrstra - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 2 issues found
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[tovrstra]

It's indeed good at catching spelling mistakes. :) Even if not all the AI comments are spot on, it just makes you rethink things, which is also helpful.