Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHP 8.0 and doctrine/mongodb-odm-bundle #168

Conversation

alexislefebvre
Copy link
Contributor

This reverts commit 6dc3c96.

Remove temporary code from #158

It will require doctrine/DoctrineMongoDBBundle#662 or doctrine/DoctrineMongoDBBundle#665

@alexislefebvre alexislefebvre marked this pull request as draft January 25, 2021 17:44
@alexislefebvre alexislefebvre mentioned this pull request Jan 25, 2021
@alexislefebvre alexislefebvre force-pushed the support-php-8.0-and-doctrine/mongodb-odm-bundle branch from 97fb5de to 0768233 Compare February 1, 2021 19:58
@alexislefebvre alexislefebvre marked this pull request as ready for review February 1, 2021 19:59
@alexislefebvre
Copy link
Contributor Author

The last version of doctrine/mongodb-odm-bundle allows PHP8. But a new error appeared:

1 Fidry\AliceDataFixtures\Bridge\Doctrine\Persister\ObjectManagerPersisterTest::testCanPersistEntitiesWithoutExplicitIdentifierSetEvenWhenExistingEntitiesHaveOne
Doctrine\DBAL\Exception\DriverException: An exception occurred while executing 'INSERT INTO Dummy (id) VALUES (null)' with params [null]:

SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens

See the full log: https://github.com/theofidry/AliceDataFixtures/pull/168/checks?check_run_id=1809551433

I don't understand what is causing this. PHP8? Doctrine? Their combination?

@alexislefebvre alexislefebvre force-pushed the support-php-8.0-and-doctrine/mongodb-odm-bundle branch from 0768233 to e6944a2 Compare June 11, 2021 12:14
@alexislefebvre alexislefebvre force-pushed the support-php-8.0-and-doctrine/mongodb-odm-bundle branch from e6944a2 to 020d315 Compare June 11, 2021 12:16
@theofidry theofidry merged commit 0177579 into theofidry:master Oct 17, 2021
@alexislefebvre
Copy link
Contributor Author

Thanks for the merge. 🚀

@alexislefebvre alexislefebvre deleted the support-php-8.0-and-doctrine/mongodb-odm-bundle branch October 18, 2021 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants