Skip to content

Commit

Permalink
fix: remove eslint-plugin-import rules
Browse files Browse the repository at this point in the history
We'll consider using eslint-plugin-import-x in the next major version,
#3
We remove this plugin to avoid issues like this: pnpm/pnpm#4619
(should be resolved when ESLint v9 is fully supported)
And because of the lack of features, that eslint-plugin-import-x implement:
(un-ts/eslint-plugin-import-x#24 (comment))
  • Loading branch information
theoludwig committed Jul 10, 2024
1 parent c751162 commit b4de437
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 1,405 deletions.
20 changes: 1 addition & 19 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"root": true,
"plugins": ["import", "promise", "unicorn"],
"plugins": ["promise", "unicorn"],
"env": {
"browser": true,
"node": true,
Expand Down Expand Up @@ -157,24 +157,6 @@
"arrow-parens": ["error", "always"],
"arrow-body-style": ["error", "always"],

"import/no-absolute-path": "error",
"import/no-webpack-loader-syntax": "error",
"import/no-self-import": "error",
"import/no-useless-path-segments": "error",
"import/export": "error",
"import/first": "error",
"import/no-duplicates": "error",
"import/order": [
"error",
{
"groups": ["builtin", "external", "internal"],
"newlines-between": "always"
}
],
"import/no-named-default": "error",
"import/no-empty-named-blocks": "error",
"import/no-anonymous-default-export": "error",

"promise/param-names": "error",
"promise/no-new-statics": "error",
"promise/no-multiple-resolved": "error",
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ More information about **formatting rules** vs **code-quality rules** can be fou
```sh
npm install --save-dev \
eslint@^8.56.0 \
eslint-plugin-import@^2.29.1 \
eslint-plugin-promise@^6.1.1 \
eslint-plugin-unicorn@^53.0.0 \
eslint-config-conventions@latest
Expand All @@ -46,7 +45,6 @@ Dependencies are:

- [ESLint](https://github.com/eslint/eslint)
- 3 [ESLint Plugins](https://eslint.org/docs/user-guide/configuring/plugins)
- [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import)
- [eslint-plugin-promise](https://github.com/xjamundx/eslint-plugin-promise)
- [eslint-plugin-unicorn](https://github.com/sindresorhus/eslint-plugin-unicorn)
- This package: `eslint-config-conventions`
Expand Down
Loading

0 comments on commit b4de437

Please sign in to comment.