Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tighten types on Property class #24

Merged
merged 2 commits into from
Jul 31, 2024
Merged

feat: Tighten types on Property class #24

merged 2 commits into from
Jul 31, 2024

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jul 26, 2024

Follow on from #23 - same reasoning and logic applies!

Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 10:06am

@DafyddLlyr DafyddLlyr changed the title feat: Tighten types on Property class feat: Tighten types on Property class Jul 27, 2024
Base automatically changed from dp/split-up-models to main July 29, 2024 10:02
Copy link
Collaborator

@zz-hh-aa zz-hh-aa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way tidier, thanks Daf! Also learned about Pick for the first time for reducing redundancy--super useful.

@DafyddLlyr DafyddLlyr merged commit eddb61a into main Jul 31, 2024
2 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/property-class branch July 31, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants