Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tidy up types on FairholdLandRent #27

Merged
merged 4 commits into from
Aug 2, 2024
Merged

feat: tidy up types on FairholdLandRent #27

merged 4 commits into from
Aug 2, 2024

Conversation

gabrielegranello
Copy link
Collaborator

Following #23 I have applied the same logic to the FairholdLandRent class

@gabrielegranello gabrielegranello requested a review from a team July 29, 2024 13:16
@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fairhold-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 2, 2024 7:01am

@DafyddLlyr
Copy link
Contributor

@gabrielegranello You might need to change the base of this PR as it's picking up changes from #23

@gabrielegranello
Copy link
Collaborator Author

Oh sorry @DafyddLlyr , I did a rebase on #23 on purpose to use the most updated Mortgage class. Should I rebase to main?

@DafyddLlyr DafyddLlyr changed the base branch from main to dp/tidy-up-mortgage-and-fairholdlandpurchase July 31, 2024 10:19
@DafyddLlyr DafyddLlyr changed the base branch from dp/tidy-up-mortgage-and-fairholdlandpurchase to main July 31, 2024 10:23
@DafyddLlyr DafyddLlyr changed the base branch from main to dp/tidy-up-mortgage-and-fairholdlandpurchase July 31, 2024 10:23
DafyddLlyr
DafyddLlyr approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@DafyddLlyr DafyddLlyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small typo but all good!

app/models/tenure/FairholdLandRent.ts Outdated Show resolved Hide resolved
@gabrielegranello @DafyddLlyr
typo fix
808e93e 
Co-authored-by: Dafydd Llŷr Pearson <DafyddLlyr@gmail.com>
@gabrielegranello gabrielegranello merged commit 57ee5da into dp/tidy-up-mortgage-and-fairholdlandpurchase Aug 2, 2024
@gabrielegranello gabrielegranello deleted the gg/fairhold-rent-tidy-up branch August 2, 2024 07:00
@DafyddLlyr DafyddLlyr mentioned this pull request Aug 2, 2024
Merged
DafyddLlyr added a commit that referenced this pull request Aug 2, 2024
@DafyddLlyr @gabrielegranello
revert: tidy up types on FairholdLandRent #27 (#37)
98a9d6a 
* typo fix

Co-authored-by: Dafydd Llŷr Pearson <DafyddLlyr@gmail.com>

* fix: Rebase issues

---------

Co-authored-by: Gabriele Granello <52770098+gabrielegranello@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielegranello @DafyddLlyr