Tidy up of the SocialRent class
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zz-hh-aa
requested changes
Jul 30, 2024
zz-hh-aa
approved these changes
Jul 30, 2024
DafyddLlyr
changed the base branch from
main
to
dp/tidy-up-mortgage-and-fairholdlandpurchase
|
Merged into |
DafyddLlyr
merged commit e047b55
into
dp/tidy-up-mortgage-and-fairholdlandpurchase
2 checks passed
This was referenced Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up of the SocialRent class following #23 .
Constant numbers also grouped and moved into
constants.ts@zz-hh-aa could you please check if I assigned the correct names to the constants? I wasn't 100% sure if I labelled them correctly