fix: ensure Gov Pay reference is set for invite to pay applications in overview HTML and CSV #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessicamcinchak
commented
Oct 14, 2024
| question: selfPayPassportKey, | ||
| responses: | ||
| (passportInstance.any([selfPayPassportKey]) as Response[]) || | ||
| (govUkPayment as unknown as Response[]), |
There was a problem hiding this comment.
I know this is ugly type casting, but does what we need with minimal cascading changes to these bits of old tedious code !
DafyddLlyr
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #help-issues report from Friday afternoon: https://opendigitalplanning.slack.com/archives/C0241GWFG4B/p1728640257349149
Depending if the applicant self-paid or invited-to-pay, the payment info will be stored differently. We've been correctly accounting for this in the ODP Schema (eg here) but NOT the CSV/Overview HTML formats and the reference number in invite to pay cases was failing to populate.
This fix correctly accounts for invite to pay cases, but ideally in the near future we'll do a larger refactor to generate the CSV & Overview HTML from the ODP Schema directly so we can remove these duplicated bespoke messy mappings!