-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade passport >= 0.6.0 #1185
Conversation
Removed vultr server and associated DNS entries |
We previously had issues upgrading this dependency. Once it hit staging and we hit I then downgraded here - #1037 There is an override in I can logout of the pizza just fine, but a console error is thrown. Happy to try again for sure on this one 👍 |
I tried to replicate this issue and I did get a console error on login ( I could not replicate the previous error related to this upgrade (the one @DafyddLlyr mentioned: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this change as thoroughly as I can and can't see where the previous issues were coming from. I'd suggest promoting to staging for more testing.
Thanks @builditben for the thorough testing here - if you could please merge this to If all's good there let's push try and push this single change onwards to production also today and draw a line under it 💪 |
This reverts commit b7c04a2.
https://github.com/theopensystemslab/planx-new/security/dependabot/1
Passport is used by Google Auth in API, to test: confirm you can login & logout of this pizza