Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade passport >= 0.6.0 #1185

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

jessicamcinchak
Copy link
Member

https://github.com/theopensystemslab/planx-new/security/dependabot/1

Passport is used by Google Auth in API, to test: confirm you can login & logout of this pizza

@github-actions
Copy link

github-actions bot commented Oct 4, 2022

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak requested a review from a team October 4, 2022 19:18
@DafyddLlyr
Copy link
Contributor

We previously had issues upgrading this dependency. Once it hit staging and we hit /logout the following error was logged - https://opensystemslab.slack.com/archives/C4B0CKQ3U/p1658848785967489

I then downgraded here - #1037

There is an override in package.json which should keep up clear of the affected sub-dependency, but upgrading passport would be good to do. Looking at the issues there and at session-cookie I'm not sure the issue is currently fixed.

I can logout of the pizza just fine, but a console error is thrown. Happy to try again for sure on this one 👍

@jessicamcinchak
Copy link
Member Author

@builditben
Copy link
Contributor

I can logout of the pizza just fine, but a console error is thrown.

I tried to replicate this issue and I did get a console error on login (Ee is not a function: https://john-opensystemslab-io.airbrake.io/projects/329753/groups/3392339330205850107?tab=overview). This error doesn't seem to be related to this specific upgrade though. I was able to replicate the same bug on a different pizza without this change.

I could not replicate the previous error related to this upgrade (the one @DafyddLlyr mentioned: TypeError: req.session.regenerate is not a function).

Copy link
Contributor

@builditben builditben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this change as thoroughly as I can and can't see where the previous issues were coming from. I'd suggest promoting to staging for more testing.

@DafyddLlyr
Copy link
Contributor

DafyddLlyr commented Oct 25, 2022

Thanks @builditben for the thorough testing here - if you could please merge this to main just now it will trigger a deploy to staging where we can test.

If all's good there let's push try and push this single change onwards to production also today and draw a line under it 💪

@jessicamcinchak jessicamcinchak merged commit b7c04a2 into main Oct 25, 2022
@jessicamcinchak jessicamcinchak deleted the jess/api-upgrade-passport branch October 25, 2022 14:19
jessicamcinchak added a commit that referenced this pull request Oct 25, 2022
jessicamcinchak added a commit that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants