chore: Fix Run API test type warnings #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed vultr server and associated DNS entries |
DafyddLlyr
force-pushed
the
dp/api-test-types
branch
from
e080d0e to
ac8ccca
Compare
DafyddLlyr
commented
Oct 26, 2023
| ?.map(([_nodeId, nodeData]) => nodeData?.data?.allowInviteToPay); | ||
| const inviteToPayEnabled = (flowGraph: FlowGraph): boolean => { | ||
| const payNodes = Object.entries(flowGraph).filter( | ||
| (entry): entry is [string, Node] => |
There was a problem hiding this comment.
The type narrowing here has to be repeated as it doesn't propagate as expected from the function which is being called.
DafyddLlyr
commented
Oct 26, 2023
| type: ComponentType, | ||
| ): entry is [string, Node] => { | ||
| const [nodeId, node] = entry; | ||
| if (nodeId === "_root") return false; |
There was a problem hiding this comment.
An alternative (and possibly better) solution to this would be to add type property to the root node (ComponentType._Root?).
jessicamcinchak
approved these changes
Oct 27, 2023
| export interface Node { | ||
| id?: string; | ||
| data?: Record<string, any>; | ||
| edges?: Array<string>; | ||
| type?: number; | ||
| } | ||
|
|
||
| /** | ||
| * @deprecated Migrating to Flow and FlowGraph from planx-core | ||
| */ |
There was a problem hiding this comment.
👍 these are helpful reminders, thanks!
There was a problem hiding this comment.
Yep - hopefully it just means when we next need to reach for a type we avoid these ones 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
planx-coreI've been staring at the message below a fair amount these past few days trying to sort E2E tests, so this is just a quick pass at addressing a few of these issues.
Next steps...
The eventual aim would be to remove the Passport / Flow etc types from the API and just use the ones from
planx-core. This isn't a small change though so I'll just try chipping away at them here and there as a maintenance task 👍