chore: update Confirmation banner description to use rich text & reword details #3545
Conversation
| ); | ||
| } | ||
|
|
||
| // TODO - Retire in favor of ODP Schema application type descriptions or fallback to flowName |
There was a problem hiding this comment.
Don't want to do this yet because we know our ODP Schema enums are a bit in flux, but imagine it will be the better / more consistent way forward ! This function only does special handling for LDCs - which is fine for now as they're the only live statutory service.
|
Removed vultr server and associated DNS entries |
| data: QuestionAndResponses[]; | ||
| } | ||
|
|
||
| export function Presentational(props: PresentationalProps) { |
There was a problem hiding this comment.
The addition of a Presentational component here is purely a convenience so we can continue mocking applicableDetails for Storybook (eg similar to Review page which is another component that relies heavily on store data). Could just as easily return this via Confirmation directly, but then Storybook would only ever display a single row "Application reference" for details section as that's gauranteed to always be in state.
There was a problem hiding this comment.
One very small comment, but all looking good. The move to just more generic language is a good one I think, thanks for cross-checking with @augustlindemer on this one 👌
Always nice to see some quality tidy ups as well!
| color: props.node?.color || { | ||
| text: "#000", | ||
| background: "rgba(1, 99, 96, 0.1)", | ||
| }, | ||
| heading: props.node?.data?.heading || "Application sent", | ||
| description: | ||
| props.node?.data?.description || | ||
| `A payment receipt has been emailed to you. You will also receive an email to confirm when your application has been received.`, | ||
| `<p>A payment receipt has been emailed to you. You will also receive an email to confirm when your application has been received.</p>`, |
There was a problem hiding this comment.
I think the standard pattern we're using here is to put the default values into the parse<COMPONENT_TYPE>() function in the associated model.ts - a little cleaner and more consistent?
Changes:
descriptionto be a rich text input instead of plain textdetailsto be handled directly in theConfirmationcomponent rather than at theNodelevelPlanning application reference→Application reference(now matches emails),Submitted→Paid at(matches actual data 🙈)Follow-ups: