Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Invite to Pay proposal.projectType validation on publish #4064

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix: remove Invite to Pay proposal.projectType validation on publish #4064

merged 1 commit into from
Dec 11, 2024

Conversation

jessicamcinchak
Copy link
Member

Context here: https://opensystemslab.slack.com/archives/C01E3AC0C03/p1733846389249239

  • The validation check that proposal.projectType needed to be set via a Checklist was too strict and preventing pre app services using SetValue components from publishing
  • Since our email templates already use a fallback value of "Project type not submitted", we can simply forgo this layer of ITP validation altogether - we still validate there is exactly one Pay component, a Send component, and that an address is collected via a FindProperty component

@jessicamcinchak jessicamcinchak requested a review from a team December 11, 2024 08:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 11, 2024 •
edited
Loading

Removed vultr server and associated DNS entries

@jessicamcinchak jessicamcinchak merged commit 1877c27 into main Dec 11, 2024
12 checks passed
@jessicamcinchak jessicamcinchak deleted the jess/itp-skip-projectType-validation branch December 11, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafyddLlyr DafyddLlyr DafyddLlyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessicamcinchak @DafyddLlyr