fix(wip): Don't allow DataAutocomplete to select the first value
#4217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DafyddLlyr
changed the title
DataAutocomplete to select the first value
DafyddLlyr
changed the title
DataAutocomplete to select the first valueDataAutocomplete to select the first value
DafyddLlyr
force-pushed
the
dp/dataautocomple-selecting-first-value
branch
from
7992480 to
288a637
Compare
|
Commenting on this mid process, you may already know about these: When shortening an existing value of a field, on lost focus it reselects existing value of that field, even if new shortened value matches any other existing values. Select hover does not clear when the cursor moves outside of the dropdown, and the last hovered item of the dropdown is selected as input on lost focus. |
DafyddLlyr
force-pushed
the
dp/dataautocomple-selecting-first-value
branch
from
288a637 to
29551c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a work in progress - getting inconsistent results locally and on pizza
What's the problem?
Currently, we're using the
autoHighlightprop (docs) which is automatically selecting the first value on focus. I don't believe that this is the intended behaviour, as highlighted by @augustlindemer here - https://opensystemslab.slack.com/archives/C5Q59R3HB/p1737660734834029?thread_ts=1737640916.451959&cid=C5Q59R3HB (OSL Slack).What's the solution?
Removing this prop (setting to the default
false) removes this behaviour. I can now enter a value, tab away / lost focus, and my new value is retained.To test...
TODO!