-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check if changes have been made before publishing a new flow #574
Conversation
✔️ Storybook 🔨 Explore the source changes: 1399125 🔍 Inspect the deploy log: https://app.netlify.com/sites/planx-storybook/deploys/6116ae760e321e0007f9751d 😎 Browse the preview: https://deploy-preview-574--planx-storybook.netlify.app |
🚀 Deployed on https://6116af020825562a5fce8ff8--planx-new.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question from today's call was: does this take into account portals? and if then, the published portals or the in-progress ones?
cce3ab4
to
c24f6e2
Compare
Re: portals - I haven't changed anything about how the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!! I ran it locally and everything worked great. I haven't tested it against of the huge flows yet but we can try that out in staging. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good!! appreciate the description with pros & cons you were thinking through and TESTS 🙌
…into sos/jsondiffpatch
The Problem
Currently, we flatten and publish flows every time a user clicks the Publish button. While this accomplishes our goal of allowing content to be manipulated and refined before it goes out to the public, it means we might be saving a lot of unnecessary data. Ideally, we can work toward something resembling version control.
Approaches
Scope of this PR
jsondiffpatch
server-sideFuture