Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Space] + Z for splitscreen results in tab errors #1

Closed
JonathanOppenheimer opened this issue Jan 16, 2023 · 6 comments
Closed

[Space] + Z for splitscreen results in tab errors #1

JonathanOppenheimer opened this issue Jan 16, 2023 · 6 comments

Comments

@JonathanOppenheimer
Copy link

When creating a new split-screen with [Space] + z within Theovim, a new tab called zsh is automatically created.
Screenshot 2023-01-16 at 3 50 28 PM

Attempting to close this tab results in errors:
Screenshot 2023-01-16 at 3 50 36 PM

It is then impossible to close the automatically created zsh tab without closing the split-screen view. This occurs every single time the split-screen is started.

@theopn
Copy link
Owner

theopn commented Jan 16, 2023

Hi Jonathan. It is an intended behavior of BarBar plugin (and other vim "buffer" based "tab" plugin) to create a new "tab" when a different buffer is introduced. Vim traditionally never had a generic "tab" that many people are used to, rather they treated "buffer" as the tab feature. Thus, it is natural for BarBar to create a new tab when a new buffer is introduced.

Simply put, even if you create a new split screen, if it is the same buffer as an existing buffer, it will not create a "tab." Even if the window is within a "tab," if it is a new buffer, it will be reflected in the BarBar plugin.

The error itself is related to NVimTree auto-closing mechanism. I am aware that NVimTree author does not recommend auto-open/auto-closing implementation as it is very error-prone and that my implementation is kind of a workaround.

I am planning on creating a new repository for my Neovim setup. Within that project, I will look into a new tab plugin that behaves more like a "traditional tab" if there is a high demand for it. I will also "fix" the NVimTree auto-closing mechanism, I will likely follow the plugin author's advice and remove the auto-open/auto-closing function as there other more efficient file browsing mechanisms such as Telescope plugin.

Please open the issue in the new project https://github.com/theopn/theovim/ once the repository has been initialized if the issue persists after the first release. Thanks.

@theopn theopn closed this as completed Jan 16, 2023
@JonathanOppenheimer
Copy link
Author

Hello Theo. I appreciate your timely response and excellent explanation of the cause of this error. I completely understand the cause of this error now and also see why it is a lower-priority issue. Nonetheless, as a representative of one of the largest user groups for Theovim, I can attest that those I represent express a desire for a tabbing feature.

I look forward to the future of Theovim's development with great interest and will certainly be tracking the new repository and its first release.

Best,
Jonathan

@theopn
Copy link
Owner

theopn commented Jan 16, 2023

Lmao thanks Jonathan see you on Wednesday

@JonathanOppenheimer
Copy link
Author

Hello sir. As per above,

Please open the issue in the new project https://github.com/theopn/theovim/ once the repository has been initialized if the issue persists after the first release. Thanks.

I have reopened this issue as the described behavior still persists when using Theovim.

My kindest regards,
Jonathan

@JonathanOppenheimer
Copy link
Author

wait fuck i can't even reopen an issue

@theopn
Copy link
Owner

theopn commented Jan 20, 2023

@JonathanOppenheimer the issue has been resolved. The NVimTree will not open on the startup anymore, and the auto close mechanism for NvimTree has been removed, which has been error-prone (nvim-tree/nvim-tree.lua#1005). Thanks for your issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants