Auto-close not work #1005

tin-pham · 2022-02-19T22:36:44Z

OS: PopOS
Nvim Version: v0.7.0-dev
Nvim-tree-version: I just update this plugin, but i don't know how to check version of this
Bug: auto-close not work
Step to reproduce: Close the buffer while the tree open

vlstv · 2022-02-20T07:44:17Z

doesn't work for me as well

bryant-the-coder · 2022-02-20T08:04:15Z

OS: PopOS
Nvim Version: v0.7.0-dev
Nvim-tree-version: I just update this plugin, but i don't know how to check version of this
Bug: auto-close not work
Step to reproduce: Close the buffer while the tree open

font? it doesn't work for me as well

kyazdani42 · 2022-02-20T09:47:26Z

cannot reproduce, can you provide your configuration and the exact steps to reproduce ?

tin-pham · 2022-02-20T22:01:37Z

Open like this

While the cursor in the buffer, press :wq or :q to quit

The tree still live

I don't know but other people have the same issue as me, I think that the new update problem, when I update this issue start occur

kyazdani42 · 2022-02-20T22:21:00Z

cannot reproduce, can you share you complete nvim-tree configuration ?
Also if you are using packer, you can navigate to ~/.local/share/nvim/site/pack/packer/start/nvim-tree.lua and do a git log

tin-pham · 2022-02-21T21:54:29Z

cannot reproduce, can you share you complete nvim-tree configuration ? Also if you are using packer, you can navigate to ~/.local/share/nvim/site/pack/packer/start/nvim-tree.lua and do a git log

My full config
https://github.com/tin-pham/NeoVimLua

nvim-tree inside lua/nvim-tree-config

kyazdani42 · 2022-02-22T20:51:07Z

cannot reproduce with your config :/ are you sure you are on latest master ?

tin-pham · 2022-02-23T00:21:16Z

cannot reproduce with your config :/ are you sure you are on latest master ?

Yep i have updated to the last master

Some hour ago I saw the auto-close fix update, but it still not work

bryant-the-coder · 2022-02-23T05:20:33Z

@tin-pham what is your font? Auto close works for me now xD

tin-pham · 2022-02-24T00:39:28Z

@tin-pham what is your font? Auto close works for me now xD

I used Operator Mono. I still have no luck 😞

bryant-the-coder · 2022-02-24T04:29:18Z

so, i was mistaken xD... it didnt close by itself. Do u hvlave operator mono the latest version? @tin-pham

tin-pham · 2022-02-25T00:58:32Z

so, i was mistaken xD... it didnt close by itself. Do u hvlave operator mono the latest version? @tin-pham

I don't know, I installed it 3-4 month ago

tin-pham · 2022-02-25T10:57:52Z

For a couple of day, now i have figured it out that NeoVim problem, i reinstall it again and now it worked.

tin-pham · 2022-02-25T12:24:40Z

=)), it sooooo weird, after coding for a little while, it can't auto close again

bryant-the-coder · 2022-02-25T13:47:25Z

xD i hv nvim tree just in case

nobleach · 2022-02-26T03:07:07Z

For the past few releases, I've had the same problem. When I open a file in a new tab, or split, the tree stays open. It's annoying because i now have tab after tab that say, "Nvim Tree". This seems like a regression.

kyazdani42 · 2022-02-28T20:53:15Z

@nobleach what you describe has nothing to do with this issue. Try setting open_on_tab to false.

Sorry people but i cannot reproduce this issue, i'll leave it open if someone wants to give a shot at fixing it.

nobleach · 2022-02-28T21:38:31Z

@nobleach what you describe has nothing to do with this issue. Try setting open_on_tab to false.

Sorry people but i cannot reproduce this issue, i'll leave it open if someone wants to give a shot at fixing it.

Then I'm very sorry, I'll open another issue as open_on_tab still won't close the tree when I open a file in a new tab.

clee088 · 2022-03-16T19:29:04Z

Are you calling, require'nvim-tree'.setup {} twice by any chance? When I first configured nvim-tree via packer, I included config = function() require'nvim-tree'.setup {} end; however, I also set up an individual config file, with auto_close = true, which called the setup function again. Removed the call to setup in my packer plugins file and got auto_close to work.

nobleach · 2022-03-16T20:28:45Z

Nope, I'm only calling it once. I've been too busy to actually sit down and create a new issue. When it gets to be too big of an annoyance I'll start digging into what it can be. Just this past week nvim-tree started throwing errors when I switch to a new tab, switch back and try to close the tree.... so I'll probably need to check into that a bit as well. I'm really trying to avoid reporting issues as i get this is a project that is being worked on in someone's spare time.... and he's not getting paid to do so.

dharmx · 2022-03-17T03:15:03Z

After making changes you should recompile packer plugin specifications :PackerCompile (assuming you're using packer.nvim)
See if this helps:

lol.mp4

My config.

nobleach · 2022-03-17T13:54:00Z

I truly appreciate the time you took to put this together! Unfortunately, PackerCompile seems to do nothing. I see you have a notification plugin that alerts you to its success. I'd typically see some sort of success message in my command lines. I see no indication that anything is happening at all. I do notice your config differs quite a bit from mine, so I might look at wiping my nvim-tree config (it's from almost a year ago) and starting from scratch.

dharmx · 2022-03-17T18:21:20Z

Ah.. you should do that then. But, note that if you're lazy loading the plugin then you'd need to set the global variables beforehand.. (before the plugin is loaded) naturally that you mean that you wouldn't be able to override it's behavior if your using the config key and it'll use defaults! The require part doesn't matter.. you can set it anywhere.

-- Putting everything in config won't work.
use {
  "kyazdani42/nvim-tree.lua",
  cmd = { "NvimTreeToggle", "NvimTreeRefresh", "NvimTreeFocus" },
  config = require "nvimtree",
}

This works for me IMO

use {
  "kyazdani42/nvim-tree.lua",
  cmd = { "NvimTreeToggle", "NvimTreeRefresh", "NvimTreeFocus" },
  setup = require("configs.workflow.nvimtree").before,
  config = require("configs.workflow.nvimtree").after,
  wants = "nvim-notify",
}

NOTE: This only applies if you're lazy loading. And I should mention this as well, I'm using NVIM v0.7.0-dev+1244-g356631cba
Also, don't forget to compile. Atleast compile/restart 4 times lmao.

kyazdani42 · 2022-03-18T10:46:29Z

@nobleach do not worry about opening a new issue if you have a bug or something you cannot manage to fix. Even if it is an opensource project on people free time, we chose whenever we have time for it, it's not like it's a burden 😄
And yes, you should update your config, it has changed quite a lot in the past year.

lgds01 · 2022-03-18T14:48:48Z

i also meet this problem.And I find when I close the buffer first using :wq, I press q to close the tree, and then the origin buffer will reappear, which means i dont close the buffer completely or reopen the buffer? Need help

lgds01 · 2022-03-18T15:56:39Z

When I use the following settings, this question seems to be solved. But another question appears. When I close one of the buffers(yes, I open many buffers, so there is not only the tree in a window), all of the buffers and tree are closed.
Here is my plugins.lua

use {
    'kyazdani42/nvim-tree.lua',
    requires = {
      'kyazdani42/nvim-web-devicons', -- optional, for file icon
    },
    config = function() require'plugin-config.nvim-tree' end
}

Here is my plugin-config/nvim-tree.lua

require'nvim-tree'.setup {
  auto_close = true,
  git = {
      enable = false
  }
}

Here is my directory structure

├── init.lua
├── lua
│   ├── basic.lua
│   ├── keybindings.lua
│   ├── lsp
│   │   ├── lua.lua
│   │   ├── nvim-cmp.lua
│   │   └── setup.lua
│   ├── plugin-config
│   │   ├── bufferline.lua
│   │   ├── nvim-tree.lua
│   │   └── nvim-treesitter.lua
│   └── plugins.lua
└── plugin
    └── packer_compiled.lua

alex-courtis · 2022-03-26T04:48:42Z

But another question appears. When I close one of the buffers(yes, I open many buffers, so there is not only the tree in a window), all of the buffers and tree are closed.

Could you please raise a new bug report for this @lgds-01 ? It will get lost in this issue otherwise ;)

alex-courtis · 2022-03-27T03:39:15Z

We could put it in the Tips and Reminders section:

You can automatically close the tab/vim when nvim-tree is the last window in the tab. WARNING: other plugins or automation may interfere with this:

autocmd BufEnter * ++nested if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif

...

tomkimsour · 2022-04-28T15:17:25Z

Where should you put this line ?

kyazdani42 · 2022-04-28T17:05:09Z

in your configuration, where you want

tomkimsour · 2022-05-03T05:36:41Z

in your configuration, where you want

But this is not lua right? So what if I want to put it in a lua file ?

WingLim · 2022-05-03T07:58:47Z

You can call nvim_create_autocmd to use it like this in lua:

vim.api.nvim_create_autocmd('BufEnter', {
    command = "if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif",
    nested = true,
})

beauwilliams · 2022-05-26T02:11:04Z

This does not work for be but manually running :if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif does close the window.

Must be something to do with BufEnter. I suspect maybe caused by wilder.nvim?

beauwilliams · 2022-05-26T02:16:04Z

Still does not work for me on my setup. Pretty sure issue with wilder.nvim. Anyways. I propose we update readme as this method is cleaner and will fire less often.

vim.api.nvim_create_autocmd('Filetype', {
    pattern = "NvimTree",
    command = "if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif",
    nested = true,
})

alex-courtis · 2022-05-26T05:30:20Z

Still does not work for me on my setup. Pretty sure issue with wilder.nvim.

This "solution" is very hacky and is unlikely to work in complex configurations. It relies on events with unpredictable ordering and nesting, which may be suppressed by other plugins/automation.

Unfortunately, events are the only known means of implementing this close functionality. Of course I would be very happy if someone found a proper solution.

I propose we update readme as this method is cleaner and will fire less often.

Does the FileType approach work more reliably?

Mariownyou · 2022-05-27T22:25:05Z

why auto-close feature was removed? I don't need tree every time I open the file. How can I disable this?

alex-courtis · 2022-05-28T02:08:37Z

why auto-close feature was removed? I don't need tree every time I open the file. How can I disable this?

g:auto_close would close vim/tab when nvim-tree was the last window.

I think the functionality you want is :help nvim-tree.actions.open_file.quit_on_open

Mariownyou · 2022-05-29T11:00:06Z

Thanks, this is really what I was looking for

YanzhaoW · 2022-06-21T13:18:35Z

You can call nvim_create_autocmd to use it like this in lua:

vim.api.nvim_create_autocmd('BufEnter', {
    command = "if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif",
    nested = true,
})

This is really bad. It can cause neovim to break if you accidentally quit without saving. After that you have to shut down the whole terminal to quit neovim.

kyazdani42 · 2022-06-25T08:42:45Z

@YanzhaoW do not use it if you don't want to.

alex-courtis · 2022-06-26T01:37:03Z

This is getting silly. There is no solution here and we will not build one, nor support hacks to do it:

remove from readme/tips
add a note to help or readme like "Functionality to automatically close the tab/vim when nvim-tree is the last window in the tab is not present and will not be added, due to complexities in vim's event system."

@kyazdani42 ?

kyazdani42 · 2022-06-26T10:12:02Z

I wouldn't remove it from the readme since people might just ask how to do it again, but maybe adding more information about why we will not help people with this might be useful.

theopn · 2022-06-26T14:42:26Z

You can call nvim_create_autocmd to use it like this in lua:
vim.api.nvim_create_autocmd('BufEnter', {
    command = "if winnr('$') == 1 && bufname() == 'NvimTree_' . tabpagenr() | quit | endif",
    nested = true,
})
This is really bad. It can cause neovim to break if you accidentally quit without saving. After that you have to shut down the whole terminal to quit neovim.

It is not elegant, but you certainly do not have to close the terminal to close the Neovim. Just don't repeatedly type :q to produce million error message, use q: to bring up the command history and choose wq or q! to close the buffer.

alex-courtis · 2022-06-26T23:34:41Z

I wouldn't remove it from the readme since people might just ask how to do it again, but maybe adding more information about why we will not help people with this might be useful.

Done

PROxZIMA · 2022-07-13T17:01:37Z

Here's a small change to make it work with unsaved files.

Also I'm extremely new to neovim and lua stuff so any suggestions are welcomed.

-- nvim-tree is also there in modified buffers so this function filter it out
local modifiedBufs = function(bufs)
    local t = 0
    for k,v in pairs(bufs) do
        if v.name:match("NvimTree_") == nil then
            t = t + 1
        end
    end
    return t
end

vim.api.nvim_create_autocmd("BufEnter", {
    nested = true,
    callback = function()
        if #vim.api.nvim_list_wins() == 1 and
        vim.api.nvim_buf_get_name(0):match("NvimTree_") ~= nil and
        modifiedBufs(vim.fn.getbufinfo({bufmodified = 1})) == 0 then
            vim.cmd "quit"
        end
    end
})

also fix emmylua errors in log.lua file fixes nvim-tree#1005 fixes nvim-tree#871

nvim-tree/nvim-tree.lua#1005 (comment) seems like there not a proper way to properly auto close

alex-courtis · 2022-11-13T04:50:46Z

@PROxZIMA I have added a wiki page covering auto close.

I have added the above solution as it does function in a minimal setup. Please update if you have any new discoveries or enhancements!

carlos-rodrigo · 2023-02-08T21:52:10Z

The easiest way I found to do this is following the docs and setup the plugin in this way

require("nvim-tree").setup {
  actions = {
    open_file = {
      quit_on_open = true,
    },
  },
}

ruperlopez · 2023-07-17T12:33:56Z

In what part of my config should I put the function(s) provided?
I tried in both: nvim-tree.lua and also as a config inside of my packer manager file. Neither worked.

gegoune · 2023-07-17T12:52:38Z

@ruperlopez What functions? This seems like a generic configuration question, not an issue, please ask under Discussions.

kyazdani42 added the bug Something isn't working label Feb 21, 2022

tin-pham closed this as completed Feb 25, 2022

tin-pham reopened this Feb 25, 2022

kyazdani42 closed this as completed in 524758a Mar 27, 2022

alex-courtis mentioned this issue Jun 26, 2022

quit as last buffer #1368

Closed

ttys3 mentioned this issue Jun 28, 2022

NvimTree closes nvim when opening a folder ttys3/nvim-config#2

Open

Almo7aya pushed a commit to Almo7aya/nvim-tree.lua that referenced this issue Oct 11, 2022

chore: remove auto close

30cdc30

also fix emmylua errors in log.lua file fixes nvim-tree#1005 fixes nvim-tree#871

alex-courtis mentioned this issue Oct 17, 2022

feat: Sync nvim-tree across tabs #1662

Closed

WilliamHsieh added a commit to WilliamHsieh/dotfiles that referenced this issue Nov 6, 2022

fix(nvimtree): nvim quit when telescope on nvim .

61a3e0f

nvim-tree/nvim-tree.lua#1005 (comment) seems like there not a proper way to properly auto close

theopn mentioned this issue Jan 20, 2023

[Space] + Z for splitscreen results in tab errors theopn/theovim#1

Closed

nvim-tree locked as resolved and limited conversation to collaborators Jul 17, 2023

Auto-close not work #1005

Auto-close not work #1005

Comments

tin-pham commented Feb 19, 2022

vlstv commented Feb 20, 2022

bryant-the-coder commented Feb 20, 2022

kyazdani42 commented Feb 20, 2022

tin-pham commented Feb 20, 2022

kyazdani42 commented Feb 20, 2022

tin-pham commented Feb 21, 2022 • edited Loading

kyazdani42 commented Feb 22, 2022

tin-pham commented Feb 23, 2022

bryant-the-coder commented Feb 23, 2022

tin-pham commented Feb 24, 2022

bryant-the-coder commented Feb 24, 2022

tin-pham commented Feb 25, 2022

tin-pham commented Feb 25, 2022

tin-pham commented Feb 25, 2022

bryant-the-coder commented Feb 25, 2022

nobleach commented Feb 26, 2022

kyazdani42 commented Feb 28, 2022

nobleach commented Feb 28, 2022

clee088 commented Mar 16, 2022

nobleach commented Mar 16, 2022

dharmx commented Mar 17, 2022 • edited Loading

nobleach commented Mar 17, 2022

dharmx commented Mar 17, 2022 • edited Loading

kyazdani42 commented Mar 18, 2022

lgds01 commented Mar 18, 2022

lgds01 commented Mar 18, 2022

alex-courtis commented Mar 26, 2022

alex-courtis commented Mar 27, 2022 • edited Loading

tomkimsour commented Apr 28, 2022

kyazdani42 commented Apr 28, 2022

tomkimsour commented May 3, 2022

WingLim commented May 3, 2022 • edited Loading

beauwilliams commented May 26, 2022

beauwilliams commented May 26, 2022 • edited Loading

alex-courtis commented May 26, 2022 • edited Loading

Mariownyou commented May 27, 2022

alex-courtis commented May 28, 2022 • edited Loading

Mariownyou commented May 29, 2022

YanzhaoW commented Jun 21, 2022

kyazdani42 commented Jun 25, 2022

alex-courtis commented Jun 26, 2022

kyazdani42 commented Jun 26, 2022

theopn commented Jun 26, 2022

alex-courtis commented Jun 26, 2022

PROxZIMA commented Jul 13, 2022 • edited Loading

alex-courtis commented Nov 13, 2022

carlos-rodrigo commented Feb 8, 2023

ruperlopez commented Jul 17, 2023

gegoune commented Jul 17, 2023

tin-pham commented Feb 21, 2022 •

edited

Loading

dharmx commented Mar 17, 2022 •

edited

Loading

dharmx commented Mar 17, 2022 •

edited

Loading

alex-courtis commented Mar 27, 2022 •

edited

Loading

WingLim commented May 3, 2022 •

edited

Loading

beauwilliams commented May 26, 2022 •

edited

Loading

alex-courtis commented May 26, 2022 •

edited

Loading

alex-courtis commented May 28, 2022 •

edited

Loading

PROxZIMA commented Jul 13, 2022 •

edited

Loading