Fix Parsing of EFI_COMMON_SECTION_HEADER2 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An issue has been observed in the case of an FFS section header using the EFI_COMMON_SECTION_HEADER2 header type. If this header type is used, the self.data attribute will erroneously contain the ExtendedSize field of the header at offset 0 instead of the beginning of the section data. All header data should be stripped from self.data. This issue has been corrected by offsetting the data by 8 bytes instead of 4 bytes when EFI_COMMON_SECTION_HEADER2 is found. Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An issue has been observed in the case of an FFS section header using the EFI_COMMON_SECTION_HEADER2 header type. If this header type is used, the self.data attribute will erroneously contain the ExtendedSize field of the header at offset 0 instead of the beginning of the section data.
All header data should be stripped from self.data.
This issue has been corrected by offsetting the data by 8 bytes instead of 4 bytes when EFI_COMMON_SECTION_HEADER2 is found.