Fix to_dict() to handle FVs without a FV Name #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an FV does not contain the optional EFI_FIRMWARE_VOLUME_EXT_HEADER, then the to_dict() function will crash. The crash occurs when attempting to access the fvname attribute, because the fvname attribute does not exist in this case. The fix is to check if the fvname attribute does not exist. If it does not, set nameGuid to None. Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an FV does not contain the optional EFI_FIRMWARE_VOLUME_EXT_HEADER, then the to_dict() function will crash. The crash occurs when attempting to access the fvname attribute, because the fvname attribute does not exist in this case.
The fix is to check if the fvname attribute does not exist. If it does not, set nameGuid to None.