Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve module usage with libroot and substrate #93

Merged
merged 5 commits into from
May 16, 2024

Conversation

leptos-null
Copy link
Member

What does this implement/fix? Explain your changes.

  • Change libroot.h from being a symlink to #include the header it previously linked to
    • this fixes a module build issue on clang 11
  • Change substrate.h from being a copy of CydiaSubstrate/CydiaSubstrate.h to including it
    • Allows including substrate.h to use the CydiaSubstrate module
  • remove link declaration from libroot/module.modulemap since the user may want to link against root or root_oldabi
    • this is not a breaking change, because theos automatically links root

Checklist

  • New code follows the code rules
  • I've added modulemaps for any new libraries (e.g. see libactivator/module.modulemap): it should be possible to @import MyLibrary; in ObjC, or import MyLibrary in Swift.
  • My contribution is code written by myself from reverse-engineered headers, licensed into the Public Domain as per LICENSE.md; or, code written by myself / taken from an existing project, released under an OSI-approved license, and I've added relevant licensing credit to LICENSE.md

Does this close any currently open issues?

no

Any relevant logs, error output, etc?

Any other comments?

Where has this been tested?

Operating System: macOS

Platform: Darwin

Target Platform: iPhoneOS

Toolchain Version: Apple clang version 15.0.0 (clang-1500.3.9.4)

SDK Version: 16.5

@leptos-null leptos-null marked this pull request as ready for review March 31, 2024 00:36
@L1ghtmann L1ghtmann merged commit 34ee082 into theos:master May 16, 2024
@leptos-null leptos-null deleted the modules branch May 16, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants