-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom text search for indexers #700
Comments
I don't understand the requirement, please explain further.
…On Sat, 10 Apr 2021, 20:53 Jai Mistry, ***@***.***> wrote:
One of the major downsides with Sonarr is that you cannot enter a custom
query to send to your indexers. There has been an issue opened here
<Sonarr/Sonarr#1128> for 7 years now for this
exact feature request, but has had no traction.
Would this be something that could be implemented on Hydra instead?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#700>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNUA6KPLZSVE6DZ3QXAGYLTICNCNANCNFSM42WZGQ4A>
.
|
It sounds like he is asking to add a feature in Hydra that Sonarr is refusing to add. This issue Sonarr/Sonarr#3712 that I opened has some more info on it. So the request would be to allow hydra to parse the query coming from Sonarr and actually change/modify/delete it before passing it over to the indexers. This would be an example workflow:
The reason why this is helpful is the the query |
|
That would be really complicated to implement without either being to
specific or too imprecise. A simple regex replacement would be easy but I
don't think you could get what you want to work with it. How would hydra
know that episode 84 is season x episode y? That would require hydra to
actually parse the query, get the series media info and do this specific
replacement. That sounds really specific.
…On Sat, 10 Apr 2021, 22:11 Jai Mistry, ***@***.***> wrote:
I don't understand the requirement, please explain further.
… <#m_8004490930958831143_>
On Sat, 10 Apr 2021, 20:53 Jai Mistry, *@*.***> wrote: One of the major
downsides with Sonarr is that you cannot enter a custom query to send to
your indexers. There has been an issue opened here <Sonarr/Sonarr#1128
<Sonarr/Sonarr#1128>> for 7 years now for this
exact feature request, but has had no traction. Would this be something
that could be implemented on Hydra instead? — You are receiving this
because you are subscribed to this thread. Reply to this email directly,
view it on GitHub <#700
<#700>>, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ADNUA6KPLZSVE6DZ3QXAGYLTICNCNANCNFSM42WZGQ4A
.
@Minituff <https://github.com/Minituff>'s comment
<#700 (comment)>
explains it well.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#700 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADNUA6J5ARPL7JAXPKPDYHTTICWGNANCNFSM42WZGQ4A>
.
|
I actually think a simple regex replacement would be able to do about 50% of the work for this case. The only difficult part would be that you'd need to equate Using My Hero Academia as an example the TVDB 3 sections: Aired Order, DVD Order, and Absolute order. I'm wondering if it is possible to convert them. If that theory is correct, then the regex would look something like this: |
I don't understand why the sonarr people don't change the query if it doesn't work? Does this affect only certain indexers or would a complete change of the query before sending it to all indexers be enough? I might give that a try but having it only affect certain indexers would make it a nightmare to configure. |
What makes this even more complicated is that sonarr actually searches for the string So for this use case the config would be something like I'll give it a go. Do you have other examples I could test this against? This would also resolve #638 although that one targets the query built by hydra, not the one provided via an API request. |
Ok, I got a proof of concept working. The configuration UI will be bare-bones though because I don't expect a lot of people to use this. Example config value: In this case a query |
Done. |
Hi, is it possible that this is broken in the most recent version? test string: FairyTail 49 should work right? nothing works. it doesn't match or it ignores the episode numbers. sometimes there's also an error, telling me that episode group is not allowed in input pattern. |
The query is sent to *arr. If it doesn't work you should talk to to their devs. |
I think I am missunderstanding something. |
Oh. Holy shit, I don't even remember implementing this. I'll take a look. |
I feel you ^^, I should've looked at the code in the first place. in "CustomSearchRequestMapping.java" the comment say's: // What should happen: q=Boku no Hero Academia S4, season=4, ep=21 -> Boku no Hero Academia s04e21 //{title:the haunting} {0:.*} -> The Haunting of Bly Manor {0} so if I try: {a:the haunting} {b:.*} -> {a} {b} = the haunting {b} looks like a missing loop as only the first group gets recognized. |
I got a temporary workaround by using: fairy tail {0:.*} -> fairy tail german e{0} |
Fixed in next version. |
Thanks, does it also fox the issue that it's only applied to internal searches? |
By the way, in the future please open a new issue instead of commenting on the old one. It should work for external searches at well. Perhaps the search type does not match. Please set the logfile level to debug, enable the logging marker "Config mapping", restart hydra, recreate the problem and attach a newly created debug infos zip. |
yeah, sorry for hijacking the issue. anyway, I tried to create a debug infos file but get an undefined error: Message: undefined` The replacement works as expected now but not when sonarr is searching as the search type is "SEARCH" |
One of the major downsides with Sonarr is that you cannot enter a custom query to send to your indexers. There has been an issue opened here for 7 years now for this exact feature request, but has had no traction.
Would this be something that could be implemented on Hydra instead?
The text was updated successfully, but these errors were encountered: