Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove node-fetch types #1

Closed
wants to merge 4 commits into from
Closed

feat: remove node-fetch types #1

wants to merge 4 commits into from

Conversation

njfamirm
Copy link

@njfamirm njfamirm commented Sep 17, 2023 •
edited
Loading

Fixes google#589 Issue. Option 5.

  • Tests pass
  • Appropriate changes to README are included in PR
  • Types updated

Chnges:

  • add DOM as lib into tsconfig
  • fully remove node-fetch type

google#619

@njfamirm njfamirm mentioned this pull request Sep 17, 2023
Closed
3 tasks
@theothirteen theothirteen force-pushed the removed-node-fetch branch 2 times, most recently from a10f703 to 1f6a3d8 Compare September 18, 2023 05:46
@njfamirm njfamirm closed this Nov 15, 2023
@njfamirm njfamirm deleted the removed-node-fetch branch November 15, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njfamirm @theothirteen