Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Drop support for PHP 5.6 and 7.0; add parameter and return types #346

Closed
colinodell opened this issue Mar 11, 2019 · 5 comments
Closed
Assignees
Labels
feedback wanted We need your input!
Milestone

Comments

@colinodell
Copy link
Member

Solutions for #341 and #345 will likely break backward-compatibility and require extension authors to make changes, so it seems like now would be the best time to drop support for PHP 5.6 and 7.0, and also implement parameter/return types throughout this project. This way, extension authors only have one (larger) set of changes to make instead of breaking BC in the next release plus another future release.

This would also put us much closer toward a potential v1.0 release.

If you are a contributor or extension developer please let me know your thoughts!

@colinodell colinodell added the feedback wanted We need your input! label Mar 11, 2019
@colinodell colinodell self-assigned this Mar 11, 2019
@colinodell colinodell added this to the v0.19 milestone Mar 11, 2019
@colinodell
Copy link
Member Author

@GrahamCampbell @pmjones @mnapoli @hason You maintain popular packages built on league/commonmark. Implementing parameter/return types may impact your libraries, especially if they're custom extensions, so I'd appreciate your thoughts on whether you'd mind us bundling this breaking change with others in the upcoming major release (0.19). I'm thinking this would be better than spreading BC-breaking changes across multiple releases. I'd greatly appreciate your feedback, even if it's a simple 👍. Thanks!

@mnapoli
Copy link
Contributor

mnapoli commented Mar 13, 2019

@colinodell I use your package (thank you ❤️ ) in Couscous via FrontYAML. Here is the line where everything happens: https://github.com/mnapoli/FrontYAML/blob/master/src/Bridge/CommonMark/CommonMarkParser.php

It seems like it's all good for me!

@hason
Copy link
Contributor

hason commented Mar 13, 2019

@colinodell That's great news! I'll make new versions of packages.

@pmjones
Copy link

pmjones commented Mar 13, 2019

We lock to specific CommonMark versions, so BC breaks should not affect us unexpectedly; and we are not opposed to making changes as needed for future releases. Thanks for the advance notice!

@colinodell
Copy link
Member Author

Implemented via #350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted We need your input!
Projects
None yet
Development

No branches or pull requests

4 participants