Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than one character to be used as a symbol for MentionExtension. #514

Closed
doZennn opened this issue Jun 29, 2020 · 2 comments · Fixed by #550
Closed

Allow more than one character to be used as a symbol for MentionExtension. #514

doZennn opened this issue Jun 29, 2020 · 2 comments · Fixed by #550
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior implemented Change has been implemented
Milestone

Comments

@doZennn
Copy link

doZennn commented Jun 29, 2020

Description
Allow multiple characters as a mention symbol.

Example
Currently "symbol" can only be a single character. Would be great if we could use more than one character like so:

$config = [
    'mentions' => [
        'user_url_generator' => [
            'symbol'    => 'u:',
            'regex'     => '/^[a-z0-9]+/i',
            'generator' => $userMentionGenerator,
        ],
    ]
];
@doZennn doZennn added the enhancement New functionality or behavior label Jun 29, 2020
@markhalliwell
Copy link
Contributor

This, currently, isn't possible and will definitely require something outlined like in #492 (comment)

@markhalliwell markhalliwell added this to the v2.0 milestone Jul 20, 2020
@stale
Copy link

stale bot commented Sep 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue may be closed soon due to inactivity label Sep 19, 2020
@markhalliwell markhalliwell added do not close Issue which won't close due to inactivity and removed stale Issue may be closed soon due to inactivity labels Sep 19, 2020
@close-label close-label bot added the implemented Change has been implemented label Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior implemented Change has been implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants