Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fenced code parsing bug #676

Closed
colinodell opened this issue Jun 19, 2021 · 1 comment
Closed

Fix fenced code parsing bug #676

colinodell opened this issue Jun 19, 2021 · 1 comment
Assignees
@colinodell
Labels
bug Something isn't working right fixed Fix has been implemented spec compliance Issues or question about compliance with the CommonMark or GFM specs

Comments

@colinodell
Copy link
Member

colinodell commented Jun 19, 2021 •
edited
Loading

This library does not properly parse tilde-fenced code blocks prefixed with 1-3 spaces:

  ~~~
  # "indentation" of 2 spaces
  ~~~

This is caused by a regex that incorrectly attempts to match ~ characters at the start of the line instead of after any leading spaces.

(Fenced blocks using backtick (`) characters works fine, though.)
@colinodell colinodell added bug Something isn't working right spec compliance Issues or question about compliance with the CommonMark or GFM specs labels Jun 19, 2021
@colinodell colinodell self-assigned this Jun 19, 2021
colinodell added a commit that referenced this issue Jun 19, 2021
@colinodell
Fix incorrect parsing of tilde-fenced code blocks with leading spaces (…
32ff478 
…#676)
@colinodell
Copy link
Member Author

Fixed in 1.6.3

@colinodell colinodell added the fixed Fix has been implemented label Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colinodell colinodell

Labels
bug Something isn't working right fixed Fix has been implemented spec compliance Issues or question about compliance with the CommonMark or GFM specs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@colinodell