Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds new “symbol” config option and deprecates “inner_contents” #506

Merged
merged 9 commits into from
Jun 21, 2020
Merged

Adds new “symbol” config option and deprecates “inner_contents” #506

merged 9 commits into from
Jun 21, 2020

Conversation

markhalliwell
Copy link
Contributor

Closes #505

@markhalliwell
Adds new “symbol” config option and deprecates “inner_contents”
fc1b239 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell
Update docs, standardize on how to add icons to elements
7efaffe 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell markhalliwell changed the title [WIP] Adds new “symbol” config option and deprecates “inner_contents” Adds new “symbol” config option and deprecates “inner_contents” Jun 20, 2020
@markhalliwell
Add new test, ensuring deprecated inner_contents still works
390bab9 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell
Update CHANGELOG.md
f0c745d 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell
Add one more test to ensure config can be set to an empty symbol
f902721 
Signed-off-by: Mark Carver <mark.carver@me.com>
colinodell
colinodell requested changes Jun 21, 2020
View reviewed changes
src/Extension/HeadingPermalink/HeadingPermalinkRenderer.php Outdated Show resolved Hide resolved
docs/1.5/extensions/heading-permalinks.md Outdated Show resolved Hide resolved
docs/1.5/extensions/external-links.md Outdated Show resolved Hide resolved
docs/1.5/extensions/external-links.md Outdated Show resolved Hide resolved
docs/1.5/extensions/heading-permalinks.md Outdated Show resolved Hide resolved
@markhalliwell
Simplify “Add Icons” CSS for external links and heading permalinks
f754d69 
Signed-off-by: Mark Carver <mark.carver@me.com>
colinodell
colinodell requested changes Jun 21, 2020
View reviewed changes
Copy link
Member

@colinodell colinodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

docs/1.4/upgrading.md Outdated Show resolved Hide resolved
src/Extension/HeadingPermalink/HeadingPermalinkRenderer.php Outdated Show resolved Hide resolved
@markhalliwell
Fix 1.5 upgrading doc
fb3bc8c 
Signed-off-by: Mark Carver <mark.carver@me.com>
@markhalliwell
Escape special HTML characters in symbol
80314ae 
Signed-off-by: Mark Carver <mark.carver@me.com>
@colinodell colinodell self-assigned this Jun 21, 2020
@colinodell colinodell added this to the v1.5 milestone Jun 21, 2020
@colinodell colinodell merged commit 28db383 into thephpleague:1.5 Jun 21, 2020
@markhalliwell markhalliwell mentioned this pull request Jul 19, 2020
Merged
@markhalliwell markhalliwell deleted the heading-permalink-symbol branch August 15, 2020 10:51
@glensc glensc mentioned this pull request Mar 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinodell colinodell colinodell requested changes

Assignees

@colinodell colinodell

Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Replace "inner_contents" config option with "symbol" in Heading Permalinks
2 participants
@markhalliwell @colinodell