-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Emoji extension #546
WIP: Emoji extension #546
Conversation
Signed-off-by: Mark Carver <mark.carver@me.com>
This is looking great so far! |
I took a stab at implementing this for a project I've been working on. It's functional, but lacks a full 1:1 mapping of emoji aliases to Unicode CLDR names. I felt preserving the official names was important for internationalization. https://github.com/giberti/commonmark-emoji-extension |
The actual parsing/rendering of emojis should be handled by a separate library. That is why we're creating https://github.com/unicorn-fail/emoji (will be migrated to This issue will merely be an extension that implements that. |
Yeah, I agree! My version of building the data files is no where as far along as yours; and doesn't include the generation script because it's not pretty. 😆 |
Looking forward to switching over to this one soon. |
@giberti I'm taking a look at your extension until this is ready! :) |
Is there any update on this PR and in turn an Emoji extension for commonmark ? This is the one feature that is stopping us for moving over to commonmark fully in our project. |
This is a WIP for #421, an emoji extension implementation using https://github.com/unicorn-fail/emoji
I haven't yet actually tried this to see if it works as expected, this work is based solely on IDE reliance on API implementation.This, currently, includes a single test as a POC