Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Emoji extension #546

Closed
wants to merge 1 commit into from
Closed

WIP: Emoji extension #546

wants to merge 1 commit into from

Conversation

markhalliwell
Copy link
Contributor

@markhalliwell markhalliwell commented Sep 17, 2020

This is a WIP for #421, an emoji extension implementation using https://github.com/unicorn-fail/emoji

I haven't yet actually tried this to see if it works as expected, this work is based solely on IDE reliance on API implementation.

This, currently, includes a single test as a POC

@markhalliwell markhalliwell added enhancement New functionality or behavior needs tests New or modified code should be covered by automated test(s) do not close Issue which won't close due to inactivity labels Sep 17, 2020
@markhalliwell markhalliwell added this to the v2.0 milestone Sep 17, 2020
@markhalliwell markhalliwell changed the title WIP: Intial emoji extension WIP: Emoji extension Sep 17, 2020
Signed-off-by: Mark Carver <mark.carver@me.com>
@colinodell
Copy link
Member

This is looking great so far!

@giberti
Copy link

giberti commented Oct 1, 2020

I took a stab at implementing this for a project I've been working on. It's functional, but lacks a full 1:1 mapping of :octocat: emoji aliases to Unicode CLDR names. I felt preserving the official names was important for internationalization.

https://github.com/giberti/commonmark-emoji-extension

@markhalliwell
Copy link
Contributor Author

The actual parsing/rendering of emojis should be handled by a separate library. That is why we're creating https://github.com/unicorn-fail/emoji (will be migrated to thephpleague namespace after its documentation is finalized).

This issue will merely be an extension that implements that.

@giberti
Copy link

giberti commented Oct 1, 2020

Yeah, I agree! My version of building the data files is no where as far along as yours; and doesn't include the generation script because it's not pretty. 😆

https://github.com/giberti/emoji-data

@giberti
Copy link

giberti commented Oct 1, 2020

Looking forward to switching over to this one soon.

@glensc
Copy link
Contributor

glensc commented Mar 10, 2021

@giberti I'm taking a look at your extension until this is ready! :)

@colinodell colinodell modified the milestones: v2.0, v2.1 May 31, 2021
@colinodell colinodell modified the milestones: v2.1, v2.2 Dec 5, 2021
@colinodell colinodell modified the milestones: v2.2, v2.3 Jan 22, 2022
@colinodell colinodell modified the milestones: v2.3, v2.4 Apr 7, 2022
@base-zero
Copy link

Is there any update on this PR and in turn an Emoji extension for commonmark ? This is the one feature that is stopping us for moving over to commonmark fully in our project.

@colinodell colinodell modified the milestones: v2.4, v3.0 Feb 25, 2023
@markhalliwell markhalliwell closed this by deleting the head repository Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not close Issue which won't close due to inactivity enhancement New functionality or behavior needs tests New or modified code should be covered by automated test(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants