Change method to get label (alt text) of images; avoid double-escaping #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d hacks and double-escaping of special characters.
|
Thanks for the fix! I did a little refactoring to move all the logic into the renderer, but otherwise, this looks great to me. I'll fix the unrelated Psalm errors and have this released shortly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #806.
This adds a getLabel() method to the Image node which attempts to get a text representation of the child nodes, and calls it to generate the "alt" attribute for the final
<img>tag. This changes the previous approach which involved rendering the children and then extracting the text via regular expressions from the generated HTML. This was also causing special characters in the alt text to be double-escaped.If you like video games, it may be of interest that Gamer Guides sponsored my development of this fix.