Remove unnecessary check for hrule in parseListMarker #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time parseListMarker is called, the hrule block start was already tried. In case it matches, no further block starts are tried. So the later check is not necessary and can be removed. Mirrors commonmark/commonmark.js#19
colinodell
added
the
performance
colinodell
added a commit
that referenced
this pull request
Mar 30, 2015
Remove unnecessary check for hrule when parsing lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time parseListMarker is called, the hrule block start was already
tried. In case it matches, no further block starts are tried. So the
later check is not necessary and can be removed.
Mirrors commonmark/commonmark.js#19