JsonAPI: Including one level of linked data

[renan]

Continuation of #126 (comment)

Right now it only includes one level deep of linked data.
It is damn hard to have it all, especially when you consider #125 and you no longer have an array of item but a single item.

I think some refactoring would need to be done in order to have it nailed, starting on Manager and Scope. One depending on each other makes things harder.
The Serializer would need to keep track of included/linked data, from top to bottom, so it can ensure uniqueness.

[philsturgeon]

Can you pull recent changes and update any conflicts, then I'll get this merged. I waited a while because I planned to tackle this myself, but your solution looks good to me.

[renan]

Done.

But looking at the spec again they seem to have changed it. Instead of having:

'links' => array(
    'author' => 1,
),

It seems the new spec is:

'links' => array(
    'author' => array(
        'linkage' => array(
            'type' => 'author',
            'id' => 1,
        ),
    ),
),

A lot more verbose.
May not be a very good format to support until they don't tag a version I would say.

[philsturgeon]

Yeah, I might just wait until they’re done and then implement it fresh. Yay for dev releases!

-- 
Phil

From: Renan Gonçalves notifications@github.com
Reply: thephpleague/fractal reply@reply.github.com>
Date: May 4, 2015 at 5:55:50 AM
To: thephpleague/fractal fractal@noreply.github.com>
Cc: Phil Sturgeon me@philsturgeon.uk>
Subject:  Re: [fractal] JsonAPI: Including one level of linked data (#137)

Done.

But looking at the spec again they seem to have changed it. Instead of having:

'links' => array(
'author' => 1,
),

It seems the new spec is:

'links' => array(
'author' => array(
'linkage' => array(
'type' => 'author',
'id' => 1,
),
),
),

A lot more verbose.
May not be a very good format to support until they don't tag a version I would say.

—
Reply to this email directly or view it on GitHub.

[boris-glumpler]

According to their status page they're on RC3 atm and will only make very small tweaks from now on. Sounds like it's ok to tackle it already. Also, one of the contributors for JSON API posted this relevant comment on the FOSRestBundle repo.

[webda2l]

There are some trouble with new linkage specification json-api/json-api#623.
Maybe this current PR could be merge to avoid current limitation of one level if discussion of new JsonAPI specification take time..

[jasonlewis]

We've now merged an improved JSON API serializer.

[renan]

💯 👏