Change AbstractProvider getRandomState to only return alphanumeric states #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, this was using the default character set for RandomLib/Generator's generateString which is the base 64 character set that includes + and /. While / wasn't causing any problems, using + in a URL parameters (e.g. when the OAuth 2 server sends back the state), the + was getting interpretted as a space, which means when a straight string comparison to stored state was being done, it was returning false. This changes getRandomState to use the Generator::CHAR_ALNUM constant as its character set which solves this problem.
Changes the Generator mock to expect a character set integer (in this case 7 which is the Generator::CHAR_ALNUM constant).
|
Makes perfect sense. I'll consider this a hotfix. Released in 1.4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, this was using the default character set for
RandomLib/Generator'sgenerateStringwhich is the base 64 character set that includes "+" and "/". While "/" wasn't causing any problems, using "+" in a URL parameter (e.g. when the OAuth 2 server sends back the state in the query string), the "+" was getting interpreted as a space, which means when a straight string comparison to stored state was being done, it was returning false.This changes getRandomState to use the
Generator::CHAR_ALNUMconstant as its character set which solves this problem.